From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28F54C001B0 for ; Thu, 13 Jul 2023 04:56:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233146AbjGME41 (ORCPT ); Thu, 13 Jul 2023 00:56:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229768AbjGME40 (ORCPT ); Thu, 13 Jul 2023 00:56:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 387E11BF9; Wed, 12 Jul 2023 21:56:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CB595619DD; Thu, 13 Jul 2023 04:56:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 271DAC433C7; Thu, 13 Jul 2023 04:56:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689224184; bh=DA30+GryZBpfAHdmLD8yPsHWI+k473jW2TYgdTn6M24=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LLyQPpP8oBZjJZCrI4AbtjPNyfcyj3gpSEM6XD1soMWC2O5uMsoTpy0pK7QP4nx8m GzvGtNcwpjKvzDbrwWyqq6r+jPfSLguuNl0sq8tm4n3nalZvzm8E329HqcSC2lxzEK 1m3Ri8yRiFDeDt8NJDyn+x3rcTalgg/EsJrF33U6ygGrP4uzYKqDNbt+9KZn9sMN2H PkzsETiL8hK1GHIT8q5+uQQdfKmQMDwBoiEmhn9u8Mw1sk4sToyl5rioBBRbMsZELP 7bcbGDeZOb5IvBTQrheBtdVypWdFyLq9D59V1e0Vqy39X0B55mN65yCEYe7EE/T2qL u6I8cyUzW6FTg== Date: Wed, 12 Jul 2023 21:56:23 -0700 From: "Darrick J. Wong" To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, Wang Yugui , Dave Chinner , Christoph Hellwig , Kent Overstreet , Christoph Hellwig Subject: Re: [PATCH v4 8/9] iomap: Create large folios in the buffered write path Message-ID: <20230713045623.GM108251@frogsfrogsfrogs> References: <20230710130253.3484695-1-willy@infradead.org> <20230710130253.3484695-9-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230710130253.3484695-9-willy@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jul 10, 2023 at 02:02:52PM +0100, Matthew Wilcox (Oracle) wrote: > Use the size of the write as a hint for the size of the folio to create. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Very nice!! Reviewed-by: Darrick J. Wong --D > --- > fs/gfs2/bmap.c | 2 +- > fs/iomap/buffered-io.c | 6 ++++-- > include/linux/iomap.h | 2 +- > 3 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c > index 8d611fbcf0bd..521d1e00a0ff 100644 > --- a/fs/gfs2/bmap.c > +++ b/fs/gfs2/bmap.c > @@ -971,7 +971,7 @@ gfs2_iomap_get_folio(struct iomap_iter *iter, loff_t pos, unsigned len) > if (status) > return ERR_PTR(status); > > - folio = iomap_get_folio(iter, pos); > + folio = iomap_get_folio(iter, pos, len); > if (IS_ERR(folio)) > gfs2_trans_end(sdp); > return folio; > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c > index 5e9380cc3e83..2d3e90f4d16e 100644 > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -461,16 +461,18 @@ EXPORT_SYMBOL_GPL(iomap_is_partially_uptodate); > * iomap_get_folio - get a folio reference for writing > * @iter: iteration structure > * @pos: start offset of write > + * @len: Suggested size of folio to create. > * > * Returns a locked reference to the folio at @pos, or an error pointer if the > * folio could not be obtained. > */ > -struct folio *iomap_get_folio(struct iomap_iter *iter, loff_t pos) > +struct folio *iomap_get_folio(struct iomap_iter *iter, loff_t pos, size_t len) > { > fgf_t fgp = FGP_WRITEBEGIN | FGP_NOFS; > > if (iter->flags & IOMAP_NOWAIT) > fgp |= FGP_NOWAIT; > + fgp |= fgf_set_order(len); > > return __filemap_get_folio(iter->inode->i_mapping, pos >> PAGE_SHIFT, > fgp, mapping_gfp_mask(iter->inode->i_mapping)); > @@ -597,7 +599,7 @@ static struct folio *__iomap_get_folio(struct iomap_iter *iter, loff_t pos, > if (folio_ops && folio_ops->get_folio) > return folio_ops->get_folio(iter, pos, len); > else > - return iomap_get_folio(iter, pos); > + return iomap_get_folio(iter, pos, len); > } > > static void __iomap_put_folio(struct iomap_iter *iter, loff_t pos, size_t ret, > diff --git a/include/linux/iomap.h b/include/linux/iomap.h > index e2b836c2e119..80facb9c9e5b 100644 > --- a/include/linux/iomap.h > +++ b/include/linux/iomap.h > @@ -261,7 +261,7 @@ int iomap_file_buffered_write_punch_delalloc(struct inode *inode, > int iomap_read_folio(struct folio *folio, const struct iomap_ops *ops); > void iomap_readahead(struct readahead_control *, const struct iomap_ops *ops); > bool iomap_is_partially_uptodate(struct folio *, size_t from, size_t count); > -struct folio *iomap_get_folio(struct iomap_iter *iter, loff_t pos); > +struct folio *iomap_get_folio(struct iomap_iter *iter, loff_t pos, size_t len); > bool iomap_release_folio(struct folio *folio, gfp_t gfp_flags); > void iomap_invalidate_folio(struct folio *folio, size_t offset, size_t len); > int iomap_file_unshare(struct inode *inode, loff_t pos, loff_t len, > -- > 2.39.2 >