From: Leesoo Ahn <lsahn@ooseel.net>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Leesoo Ahn <lsahn@wewakecorp.com>
Subject: [PATCH v2] fs: inode: return proper error code in bmap()
Date: Sat, 15 Jul 2023 17:22:04 +0900 [thread overview]
Message-ID: <20230715082204.1598206-1-lsahn@wewakecorp.com> (raw)
Return -EOPNOTSUPP instead of -EINVAL which has the meaning of
the argument is an inappropriate value. The current error code doesn't
make sense to represent that a file system doesn't support bmap operation.
Signed-off-by: Leesoo Ahn <lsahn@wewakecorp.com>
---
Changes since v1:
- Modify the comments of bmap()
- Modify subject and description requested by Markus Elfring
https://lore.kernel.org/lkml/20230715060217.1469690-1-lsahn@wewakecorp.com/
fs/inode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/inode.c b/fs/inode.c
index 8fefb69e1f84..697c51ed226a 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -1831,13 +1831,13 @@ EXPORT_SYMBOL(iput);
* 4 in ``*block``, with disk block relative to the disk start that holds that
* block of the file.
*
- * Returns -EINVAL in case of error, 0 otherwise. If mapping falls into a
+ * Returns -EOPNOTSUPP in case of error, 0 otherwise. If mapping falls into a
* hole, returns 0 and ``*block`` is also set to 0.
*/
int bmap(struct inode *inode, sector_t *block)
{
if (!inode->i_mapping->a_ops->bmap)
- return -EINVAL;
+ return -EOPNOTSUPP;
*block = inode->i_mapping->a_ops->bmap(inode->i_mapping, *block);
return 0;
--
2.34.1
next reply other threads:[~2023-07-15 8:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-15 8:22 Leesoo Ahn [this message]
[not found] ` <cca223c5-b512-3913-a796-fa15341927ff@web.de>
2023-07-15 13:20 ` [PATCH v2] fs: inode: return proper error code in bmap() Leesoo Ahn
2023-07-15 14:56 ` Matthew Wilcox
2023-07-17 15:11 ` Leesoo Ahn
2023-07-15 23:36 ` Dave Chinner
2023-07-17 15:08 ` Leesoo Ahn
2023-07-17 23:08 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230715082204.1598206-1-lsahn@wewakecorp.com \
--to=lsahn@ooseel.net \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsahn@wewakecorp.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox