linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Matthew Wilcox <willy@infradead.org>,
	Christian Brauner <christian@brauner.io>,
	linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-xfs@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/6] block: open code __generic_file_write_iter for blkdev writes
Date: Thu, 20 Jul 2023 16:04:49 +0200	[thread overview]
Message-ID: <20230720140452.63817-4-hch@lst.de> (raw)
In-Reply-To: <20230720140452.63817-1-hch@lst.de>

Open code __generic_file_write_iter to remove the indirect call into
->direct_IO and to prepare using the iomap based write code.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/fops.c | 44 ++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 42 insertions(+), 2 deletions(-)

diff --git a/block/fops.c b/block/fops.c
index a286bf3325c5d8..eb599a173ef02d 100644
--- a/block/fops.c
+++ b/block/fops.c
@@ -533,6 +533,29 @@ static int blkdev_release(struct inode *inode, struct file *filp)
 	return 0;
 }
 
+static ssize_t
+blkdev_direct_write(struct kiocb *iocb, struct iov_iter *from)
+{
+	size_t count = iov_iter_count(from);
+	ssize_t written;
+
+	written = kiocb_invalidate_pages(iocb, count);
+	if (written) {
+		if (written == -EBUSY)
+			return 0;
+		return written;
+	}
+
+	written = blkdev_direct_IO(iocb, from);
+	if (written > 0) {
+		kiocb_invalidate_post_direct_write(iocb, count);
+		iocb->ki_pos += written;
+	}
+	if (written != -EIOCBQUEUED)
+		iov_iter_revert(from, count - written - iov_iter_count(from));
+	return written;
+}
+
 /*
  * Write data to the block device.  Only intended for the block device itself
  * and the raw driver which basically is a fake block device.
@@ -542,7 +565,8 @@ static int blkdev_release(struct inode *inode, struct file *filp)
  */
 static ssize_t blkdev_write_iter(struct kiocb *iocb, struct iov_iter *from)
 {
-	struct block_device *bdev = I_BDEV(iocb->ki_filp->f_mapping->host);
+	struct file *file = iocb->ki_filp;
+	struct block_device *bdev = I_BDEV(file->f_mapping->host);
 	struct inode *bd_inode = bdev->bd_inode;
 	loff_t size = bdev_nr_bytes(bdev);
 	size_t shorted = 0;
@@ -569,7 +593,23 @@ static ssize_t blkdev_write_iter(struct kiocb *iocb, struct iov_iter *from)
 		iov_iter_truncate(from, size);
 	}
 
-	ret = __generic_file_write_iter(iocb, from);
+	ret = file_remove_privs(file);
+	if (ret)
+		return ret;
+
+	ret = file_update_time(file);
+	if (ret)
+		return ret;
+
+	if (iocb->ki_flags & IOCB_DIRECT) {
+		ret = blkdev_direct_write(iocb, from);
+		if (ret >= 0 && iov_iter_count(from))
+			ret = direct_write_fallback(iocb, from, ret,
+					generic_perform_write(iocb, from));
+	} else {
+		ret = generic_perform_write(iocb, from);
+	}
+
 	if (ret > 0)
 		ret = generic_write_sync(iocb, ret);
 	iov_iter_reexpand(from, iov_iter_count(from) + shorted);
-- 
2.39.2


  parent reply	other threads:[~2023-07-20 14:05 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-20 14:04 allow building a kernel without buffer_heads Christoph Hellwig
2023-07-20 14:04 ` [PATCH 1/6] fs: remove emergency_thaw_bdev Christoph Hellwig
2023-07-20 14:12   ` Johannes Thumshirn
2023-07-20 15:43   ` Hannes Reinecke
2023-07-24 19:54   ` Luis Chamberlain
2023-07-20 14:04 ` [PATCH 2/6] fs: rename and move block_page_mkwrite_return Christoph Hellwig
2023-07-20 14:13   ` Johannes Thumshirn
2023-07-20 15:45   ` Hannes Reinecke
2023-07-24 19:55   ` Luis Chamberlain
2023-07-20 14:04 ` Christoph Hellwig [this message]
2023-07-20 14:14   ` [PATCH 3/6] block: open code __generic_file_write_iter for blkdev writes Johannes Thumshirn
2023-07-20 15:46   ` Hannes Reinecke
2023-07-24 20:05   ` Luis Chamberlain
2023-07-20 14:04 ` [PATCH 4/6] block: stop setting ->direct_IO Christoph Hellwig
2023-07-20 14:15   ` Johannes Thumshirn
2023-07-20 15:46   ` Hannes Reinecke
2023-07-24 20:07   ` Luis Chamberlain
2023-07-20 14:04 ` [PATCH 5/6] block: use iomap for writes to block devices Christoph Hellwig
2023-07-20 15:48   ` Hannes Reinecke
2023-07-24 20:14   ` Luis Chamberlain
     [not found]   ` <CGME20230727091404eucas1p2cbc14ec51eb1442496b1a4c30cd04803@eucas1p2.samsung.com>
2023-07-27  9:14     ` Pankaj Raghav
2023-07-20 14:04 ` [PATCH 6/6] fs: add CONFIG_BUFFER_HEAD Christoph Hellwig
2023-07-20 14:45   ` Matthew Wilcox
2023-07-21  6:24     ` Christoph Hellwig
2023-07-20 15:53   ` Hannes Reinecke
2023-07-21  6:25     ` Christoph Hellwig
2023-07-24 20:16   ` Luis Chamberlain
2023-07-20 14:51 ` allow building a kernel without buffer_heads Bob Peterson
2023-07-21  6:26   ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2023-08-01 17:21 allow building a kernel without buffer_heads v3 Christoph Hellwig
2023-08-01 17:21 ` [PATCH 3/6] block: open code __generic_file_write_iter for blkdev writes Christoph Hellwig
2023-08-01 17:48   ` Hannes Reinecke
2023-08-01 18:11   ` Luis Chamberlain
2023-08-02  7:26   ` Christian Brauner
2023-08-02 10:06   ` Johannes Thumshirn
2023-08-29  2:06   ` Al Viro
2023-08-29 13:03     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230720140452.63817-4-hch@lst.de \
    --to=hch@lst.de \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=christian@brauner.io \
    --cc=djwong@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).