From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2618C0015E for ; Wed, 26 Jul 2023 12:51:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231785AbjGZMvu (ORCPT ); Wed, 26 Jul 2023 08:51:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232312AbjGZMvt (ORCPT ); Wed, 26 Jul 2023 08:51:49 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A3C31FF3 for ; Wed, 26 Jul 2023 05:51:22 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 29A236732A; Wed, 26 Jul 2023 14:51:07 +0200 (CEST) Date: Wed, 26 Jul 2023 14:51:06 +0200 From: Christoph Hellwig To: Christian Brauner Cc: Christoph Hellwig , viro@zeniv.linux.org.uk, jack@suse.cz, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] fs: open the block device after allocation the super_block Message-ID: <20230726125106.GA14306@lst.de> References: <20230724175145.201318-1-hch@lst.de> <20230725-tagebuch-gerede-a28f8fd8084a@brauner> <20230725-einnahmen-warnschilder-17779aec0a97@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725-einnahmen-warnschilder-17779aec0a97@brauner> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Jul 25, 2023 at 06:32:05PM +0200, Christian Brauner wrote: > I've removed the references to bind mounts from the commit message. > I mentioned in [1] and [2] that this problem is really related to > superblocks at it's core. It's just that technically a bind-mount would > be created in the following scenario where two processes race to create > a superblock: I wanted to keep some of Jan's original logic. In the end a bind mount is just one of many reuses of a super block so I think your updated log is fine. Btw, it might make sense to place this on a separate branch, and Jan's block work will have to pull it in, and it might be good to not require the entire vfs misc tree to be pult in.