From: Christian Brauner <brauner@kernel.org>
To: Jeff Layton <jlayton@kernel.org>
Cc: Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] fs: compare truncated timestamps in current_mgtime
Date: Fri, 28 Jul 2023 17:21:17 +0200 [thread overview]
Message-ID: <20230728-insel-zukauf-e3da5defe5a2@brauner> (raw)
In-Reply-To: <20230728-mgctime-v1-1-5b0ddc5df08e@kernel.org>
On Fri, 28 Jul 2023 09:21:37 -0400, Jeff Layton wrote:
> current_mgtime compares the ctime (which has already been truncated) to
> the value from ktime_get_coarse_real_ts64 (which has not). All of the
> existing filesystems that enable mgtime have 1ns granularity, so this is
> not a problem today, but it is more correct to compare truncated
> timestamps instead.
>
> Do the truncate earlier, so we're comparing like things.
>
> [...]
Applied to the vfs.ctime branch of the vfs/vfs.git tree.
Patches in the vfs.ctime branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.ctime
[1/1] fs: compare truncated timestamps in current_mgtime
https://git.kernel.org/vfs/vfs/c/dec705a2d44a
prev parent reply other threads:[~2023-07-28 15:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 13:21 [PATCH] fs: compare truncated timestamps in current_mgtime Jeff Layton
2023-07-28 15:21 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728-insel-zukauf-e3da5defe5a2@brauner \
--to=brauner@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).