From: Andrew Morton <akpm@linux-foundation.org>
To: Zhu Wang <wangzhu9@huawei.com>
Cc: <linux-kernel@vger.kernel.org>,
Al.Smith@aeschi.ch.eu.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH -next] efs: fix -Wunused-const-variable= warning
Date: Wed, 2 Aug 2023 10:02:48 -0700 [thread overview]
Message-ID: <20230802100248.b6e24e19f33e483d4cf55512@linux-foundation.org> (raw)
In-Reply-To: <20230802065753.217179-1-wangzhu9@huawei.com>
On Wed, 2 Aug 2023 14:57:53 +0800 Zhu Wang <wangzhu9@huawei.com> wrote:
> When building with W=1, the following warning occurs.
>
> In file included from fs/efs/super.c:18:0:
> fs/efs/efs.h:22:19: warning: ‘cprt’ defined but not used [-Wunused-const-variable=]
> static const char cprt[] = "EFS: "EFS_VERSION" - (c) 1999 Al Smith
> <Al.Smith@aeschi.ch.eu.org>";
> ^~~~
> The header file is included in many C files, there are many
> similar errors which are not included here. We add __maybe_unsed
> to remove it.
>
> ...
>
> --- a/fs/efs/efs.h
> +++ b/fs/efs/efs.h
> @@ -19,7 +19,8 @@
>
> #define EFS_VERSION "1.0a"
>
> -static const char cprt[] = "EFS: "EFS_VERSION" - (c) 1999 Al Smith <Al.Smith@aeschi.ch.eu.org>";
> +static const char __maybe_unused cprt[] =
> + "EFS: "EFS_VERSION" - (c) 1999 Al Smith <Al.Smith@aeschi.ch.eu.org>";
>
>
> /* 1 block is 512 bytes */
I don't know if Al is still around, but I added the Cc anyway.
cprt[] is unreferenced in fs/efs/*.c. I assume the intent here was to
embed the copyright strings in the generated binary. But this doesn't
work nowadays - the compiler/linker are removing this string entirely.
I guess the best approach is to move this copyright statement into a
comment as we do in many other places. See fs/ext2/acl.c for a random
example.
parent reply other threads:[~2023-08-02 17:03 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230802065753.217179-1-wangzhu9@huawei.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230802100248.b6e24e19f33e483d4cf55512@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Al.Smith@aeschi.ch.eu.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangzhu9@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).