From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74D22C04A6A for ; Wed, 2 Aug 2023 15:35:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235289AbjHBPfM (ORCPT ); Wed, 2 Aug 2023 11:35:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235247AbjHBPe6 (ORCPT ); Wed, 2 Aug 2023 11:34:58 -0400 Received: from outbound-smtp59.blacknight.com (outbound-smtp59.blacknight.com [46.22.136.243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B85B211B for ; Wed, 2 Aug 2023 08:34:32 -0700 (PDT) Received: from mail.blacknight.com (pemlinmail04.blacknight.ie [81.17.254.17]) by outbound-smtp59.blacknight.com (Postfix) with ESMTPS id 4628FFAE5D for ; Wed, 2 Aug 2023 16:34:24 +0100 (IST) Received: (qmail 29631 invoked from network); 2 Aug 2023 15:34:24 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.20.191]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 2 Aug 2023 15:34:23 -0000 Date: Wed, 2 Aug 2023 16:34:21 +0100 From: Mel Gorman To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Andrew Morton , Linus Torvalds , liubo , Peter Xu , Matthew Wilcox , Hugh Dickins , Jason Gunthorpe , John Hubbard , Mel Gorman , Shuah Khan , Paolo Bonzini Subject: Re: [PATCH v2 6/8] mm/huge_memory: remove stale NUMA hinting comment from follow_trans_huge_pmd() Message-ID: <20230802153421.x5455znvogns5dfv@techsingularity.net> References: <20230801124844.278698-1-david@redhat.com> <20230801124844.278698-7-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230801124844.278698-7-david@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Aug 01, 2023 at 02:48:42PM +0200, David Hildenbrand wrote: > That comment for pmd_protnone() was added in commit 2b4847e73004 > ("mm: numa: serialise parallel get_user_page against THP migration"), which > noted: > > THP does not unmap pages due to a lack of support for migration > entries at a PMD level. This allows races with get_user_pages > > Nowadays, we do have PMD migration entries, so the comment no longer > applies. Let's drop it. > > Signed-off-by: David Hildenbrand Acked-by: Mel Gorman -- Mel Gorman SUSE Labs