From: Jan Kara <jack@suse.cz>
To: Christian Brauner <brauner@kernel.org>
Cc: Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@lst.de>,
Al Viro <viro@zeniv.linux.org.uk>,
David Howells <dhowells@redhat.com>,
Aleksa Sarai <cyphar@cyphar.com>, Karel Zak <kzak@redhat.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH RFC 2/3] fs: add vfs_cmd_create()
Date: Wed, 2 Aug 2023 19:13:02 +0200 [thread overview]
Message-ID: <20230802171302.5kceref6gp7wn3os@quack3> (raw)
In-Reply-To: <20230802170155.l7sru3projdgsna5@quack3>
On Wed 02-08-23 19:01:55, Jan Kara wrote:
> On Tue 01-08-23 15:09:01, Christian Brauner wrote:
> > Split the steps to create a superblock into a tiny helper. This will
> > make the next patch easier to follow.
> >
> > Signed-off-by: Christian Brauner <brauner@kernel.org>
>
> I agree with Christoph that the error handling in vfs_fsconfig_locked() is
> confusing - in particular the fact that if you 'break' out of the switch
> statement it causes the fs context to be marked as failed is probably handy
> but too subtle to my taste.
>
> Also I think this patch does cause a behavioral change because before if we
> bailed e.g. due to:
>
> if (fc->phase != FS_CONTEXT_CREATE_PARAMS)
>
> we returned -EBUSY but didn't set fc->phase = FS_CONTEXT_FAILED. After your
> patch we 'break' on any error and thus fc->phase is set on any error...
Ah, I can see you've already posted v2 where you addressed this problem.
Sorry for the noise.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2023-08-02 17:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 13:08 [PATCH RFC 0/3] fs: allow userspace to detect superblock reuse Christian Brauner
2023-08-01 13:09 ` [PATCH RFC 1/3] super: remove get_tree_single_reconf() Christian Brauner
2023-08-01 15:31 ` Christoph Hellwig
2023-08-02 7:20 ` Christian Brauner
2023-08-02 16:49 ` Jan Kara
2023-08-01 13:09 ` [PATCH RFC 2/3] fs: add vfs_cmd_create() Christian Brauner
2023-08-01 15:43 ` Christoph Hellwig
2023-08-01 15:48 ` Christoph Hellwig
2023-08-02 8:02 ` Christian Brauner
2023-08-02 17:01 ` Jan Kara
2023-08-02 17:13 ` Jan Kara [this message]
2023-08-01 13:09 ` [PATCH RFC 3/3] fs: add FSCONFIG_CMD_CREATE_EXCL Christian Brauner
2023-08-01 15:46 ` Christoph Hellwig
2023-08-02 7:38 ` Christian Brauner
2023-08-01 14:25 ` [PATCH RFC 0/3] fs: allow userspace to detect superblock reuse Josef Bacik
2023-08-02 7:49 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230802171302.5kceref6gp7wn3os@quack3 \
--to=jack@suse.cz \
--cc=brauner@kernel.org \
--cc=cyphar@cyphar.com \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=kzak@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).