From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A83AC04E69 for ; Thu, 3 Aug 2023 13:17:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236250AbjHCNRd (ORCPT ); Thu, 3 Aug 2023 09:17:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235982AbjHCNRG (ORCPT ); Thu, 3 Aug 2023 09:17:06 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 818E1359E; Thu, 3 Aug 2023 06:16:41 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 36FEB21940; Thu, 3 Aug 2023 13:16:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1691068600; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=u354+D6fXMwflzIguDkXJwfsSkO6vRI2JZd9gBpk1w8=; b=OInI+ey5VB7bzlioGeMTFK6cIMQcbmPzuBjm1cod6P5t4UnAeQVLtUmUu1ow9TDDPGWiPS atDqYLDfOQiSeLf9a8Mxe+jzJt4kWnT5rRiebmQjJeWOqxCO++WGDUVBxHjKk+yd1qbRDm s/39yG0lPvvzKys6HDoWqHVcWWAMeF8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1691068600; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=u354+D6fXMwflzIguDkXJwfsSkO6vRI2JZd9gBpk1w8=; b=SmreZ91bm3h8DRDbHSeo79QkJcwnmaQYt9hiZl0HQQG8+NzwgUM1M7+nZhg4RER1VLY2aq a6c0libI9aZYmsBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 28A5C134B0; Thu, 3 Aug 2023 13:16:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /jbsCbioy2RJagAAMHmgww (envelope-from ); Thu, 03 Aug 2023 13:16:40 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id A4DE7A076B; Thu, 3 Aug 2023 15:16:39 +0200 (CEST) Date: Thu, 3 Aug 2023 15:16:39 +0200 From: Jan Kara To: Christoph Hellwig Cc: Al Viro , Christian Brauner , Jan Kara , Chris Mason , Josef Bacik , David Sterba , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , Chao Yu , Ryusuke Konishi , "Darrick J. Wong" , Jens Axboe , linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 08/12] fs: export fs_holder_ops Message-ID: <20230803131639.eq6i7hq7mo4nvinr@quack3> References: <20230802154131.2221419-1-hch@lst.de> <20230802154131.2221419-9-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230802154131.2221419-9-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed 02-08-23 17:41:27, Christoph Hellwig wrote: > Export fs_holder_ops so that file systems that open additional block > devices can use it as well. > > Signed-off-by: Christoph Hellwig Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/super.c | 3 ++- > include/linux/blkdev.h | 2 ++ > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fs/super.c b/fs/super.c > index 0cda4af0a7e16c..dac05f96ab9ac8 100644 > --- a/fs/super.c > +++ b/fs/super.c > @@ -1244,9 +1244,10 @@ static void fs_mark_dead(struct block_device *bdev) > up_read(&sb->s_umount); > } > > -static const struct blk_holder_ops fs_holder_ops = { > +const struct blk_holder_ops fs_holder_ops = { > .mark_dead = fs_mark_dead, > }; > +EXPORT_SYMBOL_GPL(fs_holder_ops); > > static int set_bdev_super(struct super_block *s, void *data) > { > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index ed44a997f629f5..83262702eea71a 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -1464,6 +1464,8 @@ struct blk_holder_ops { > void (*mark_dead)(struct block_device *bdev); > }; > > +extern const struct blk_holder_ops fs_holder_ops; > + > /* > * Return the correct open flags for blkdev_get_by_* for super block flags > * as stored in sb->s_flags. > -- > 2.39.2 > -- Jan Kara SUSE Labs, CR