From: Christian Brauner <brauner@kernel.org>
To: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
Cc: xiubli@redhat.com, stgraber@ubuntu.com,
linux-fsdevel@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
Ilya Dryomov <idryomov@gmail.com>,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 04/12] ceph: add enable_unsafe_idmap module parameter
Date: Fri, 4 Aug 2023 16:54:03 +0200 [thread overview]
Message-ID: <20230804-erdtrabanten-mitunter-12aa02867edc@brauner> (raw)
In-Reply-To: <20230804084858.126104-5-aleksandr.mikhalitsyn@canonical.com>
On Fri, Aug 04, 2023 at 10:48:50AM +0200, Alexander Mikhalitsyn wrote:
> This parameter is used to decide if we allow
> to perform IO on idmapped mount in case when MDS lacks
> support of CEPHFS_FEATURE_HAS_OWNER_UIDGID feature.
>
> In this case we can't properly handle MDS permission
> checks and if UID/GID-based restrictions are enabled
> on the MDS side then IO requests which go through an
> idmapped mount may fail with -EACCESS/-EPERM.
> Fortunately, for most of users it's not a case and
> everything should work fine. But we put work "unsafe"
> in the module parameter name to warn users about
> possible problems with this feature and encourage
> update of cephfs MDS.
>
> Cc: Xiubo Li <xiubli@redhat.com>
> Cc: Jeff Layton <jlayton@kernel.org>
> Cc: Ilya Dryomov <idryomov@gmail.com>
> Cc: ceph-devel@vger.kernel.org
> Suggested-by: Stéphane Graber <stgraber@ubuntu.com>
> Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
> ---
Seems good enough,
Acked-by: Christian Brauner <brauner@kernel.org>
next prev parent reply other threads:[~2023-08-04 14:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 8:48 [PATCH v9 00/12] ceph: support idmapped mounts Alexander Mikhalitsyn
2023-08-04 8:48 ` [PATCH v9 01/12] fs: export mnt_idmap_get/mnt_idmap_put Alexander Mikhalitsyn
2023-08-04 8:48 ` [PATCH v9 02/12] ceph: stash idmapping in mdsc request Alexander Mikhalitsyn
2023-08-04 8:48 ` [PATCH v9 03/12] ceph: handle idmapped mounts in create_request_message() Alexander Mikhalitsyn
2023-08-04 14:53 ` Christian Brauner
2023-08-05 1:55 ` kernel test robot
2023-08-05 9:15 ` Aleksandr Mikhalitsyn
2023-08-07 1:24 ` Xiubo Li
2023-08-07 6:51 ` Aleksandr Mikhalitsyn
2023-08-07 10:28 ` Xiubo Li
2023-08-07 10:34 ` Aleksandr Mikhalitsyn
2023-08-07 11:21 ` Xiubo Li
2023-08-07 11:28 ` Aleksandr Mikhalitsyn
2023-08-07 11:45 ` Aleksandr Mikhalitsyn
2023-08-04 8:48 ` [PATCH v9 04/12] ceph: add enable_unsafe_idmap module parameter Alexander Mikhalitsyn
2023-08-04 14:54 ` Christian Brauner [this message]
2023-08-04 8:48 ` [PATCH v9 05/12] ceph: pass an idmapping to mknod/symlink/mkdir Alexander Mikhalitsyn
2023-08-04 8:48 ` [PATCH v9 06/12] ceph: allow idmapped getattr inode op Alexander Mikhalitsyn
2023-08-04 8:48 ` [PATCH v9 07/12] ceph: allow idmapped permission " Alexander Mikhalitsyn
2023-08-04 8:48 ` [PATCH v9 08/12] ceph: pass idmap to __ceph_setattr Alexander Mikhalitsyn
2023-08-04 14:55 ` Christian Brauner
2023-08-04 8:48 ` [PATCH v9 09/12] ceph: allow idmapped setattr inode op Alexander Mikhalitsyn
2023-08-04 8:48 ` [PATCH v9 10/12] ceph/acl: allow idmapped set_acl " Alexander Mikhalitsyn
2023-08-04 8:48 ` [PATCH v9 11/12] ceph/file: allow idmapped atomic_open " Alexander Mikhalitsyn
2023-08-04 8:48 ` [PATCH v9 12/12] ceph: allow idmapped mounts Alexander Mikhalitsyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230804-erdtrabanten-mitunter-12aa02867edc@brauner \
--to=brauner@kernel.org \
--cc=aleksandr.mikhalitsyn@canonical.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stgraber@ubuntu.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox