linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: Christian Brauner <brauner@kernel.org>,
	linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] file: mostly eliminate spurious relocking in __range_close
Date: Fri,  4 Aug 2023 18:49:58 +0200	[thread overview]
Message-ID: <20230804-hubschrauber-hypothek-e8003cd3fbec@brauner> (raw)
In-Reply-To: <20230727113809.800067-1-mjguzik@gmail.com>

On Thu, 27 Jul 2023 13:38:09 +0200, Mateusz Guzik wrote:
> Stock code takes a lock trip for every fd in range, but this can be
> trivially avoided and real-world consumers do have plenty of already
> closed cases.
> 
> Just booting Debian 12 with a debug printk shows:
> (sh) min 3 max 17 closed 15 empty 0
> (sh) min 19 max 63 closed 31 empty 14
> (sh) min 4 max 63 closed 0 empty 60
> (spawn) min 3 max 63 closed 13 empty 48
> (spawn) min 3 max 63 closed 13 empty 48
> (mount) min 3 max 17 closed 15 empty 0
> (mount) min 19 max 63 closed 32 empty 13
> 
> [...]

massaged it a bit

---

Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc

[1/1] file: mostly eliminate spurious relocking in __range_close
      https://git.kernel.org/vfs/vfs/c/215baa741614

           reply	other threads:[~2023-08-04 16:50 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20230727113809.800067-1-mjguzik@gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230804-hubschrauber-hypothek-e8003cd3fbec@brauner \
    --to=brauner@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjguzik@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).