From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9DD9C001DE for ; Mon, 7 Aug 2023 09:32:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231578AbjHGJcb (ORCPT ); Mon, 7 Aug 2023 05:32:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231573AbjHGJc3 (ORCPT ); Mon, 7 Aug 2023 05:32:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A8DB10E0 for ; Mon, 7 Aug 2023 02:32:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9D9A86171D for ; Mon, 7 Aug 2023 09:32:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08119C433C8; Mon, 7 Aug 2023 09:32:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691400747; bh=DpNYwtYrwfljS4CMIV07Nd0nS/vqOGyRd8hR2TtIQY0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uZZhcbFUJlt23mAm8ggkcMaD4EC3gdcbtbg+fV/MDTf705mzrAPJ07gWILmEnmm1x uNVMUNZRV1+04M/z6R//cdteHxYv7Newqrz7AtJqYKNg7fEjt9izrCu7Xsg0Xw0qtF acMRwlKGJXz+WE1GdeiqK5j+I6pWKQYvok1f6w1IQjKev/th17EEL9Yc9replv1r0c OjRXQHT+f4wnyqIffIPHi8qcCBKD+VovjctZx02l1CCyzE0J9J5oRBBbzCEQy9zP1M Uepa2jhR+oyVTAaa42fdGvNoxpy2sDK8Mmq3RG2474YSM1jqoZbQGuIfDv93EcJg7n taseiX50VeTsw== Date: Mon, 7 Aug 2023 11:32:22 +0200 From: Carlos Maiolino To: Christian Brauner Cc: Hugh Dickins , Jan Kara , Dan Carpenter , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH vfs.tmpfs] shmem: move spinlock into shmem_recalc_inode() to fix quota support Message-ID: <20230807093222.o46d7kexapywe5jl@andromeda> References: <29f48045-2cb5-7db-ecf1-72462f1bef5@google.com> <20230804-legalisieren-neukonzeption-97314400abbd@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230804-legalisieren-neukonzeption-97314400abbd@brauner> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Aug 04, 2023 at 11:31:33AM +0200, Christian Brauner wrote: > On Thu, 03 Aug 2023 22:46:11 -0700, Hugh Dickins wrote: > > Commit "shmem: fix quota lock nesting in huge hole handling" was not so > > good: Smatch caught shmem_recalc_inode()'s shmem_inode_unacct_blocks() > > descending into quota_send_warning(): where blocking GFP_NOFS is used, > > yet shmem_recalc_inode() is called holding the shmem inode's info->lock. > > > > Yes, both __dquot_alloc_space() and __dquot_free_space() are commented > > "This operation can block, but only after everything is updated" - when > > calling flush_warnings() at the end - both its print_warning() and its > > quota_send_warning() may block. > > > > [...] > > Applied to the vfs.tmpfs branch of the vfs/vfs.git tree. > Patches in the vfs.tmpfs branch should appear in linux-next soon. > > Please report any outstanding bugs that were missed during review in a > new review to the original patch series allowing us to drop it. > > It's encouraged to provide Acked-bys and Reviewed-bys even though the > patch has now been applied. If possible patch trailers will be updated. > > Note that commit hashes shown below are subject to change due to rebase, > trailer updates or similar. If in doubt, please check the listed branch. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git > branch: vfs.tmpfs > > [1/1] shmem: move spinlock into shmem_recalc_inode() to fix quota support > https://git.kernel.org/vfs/vfs/c/f384c361c99e Once Hugh patch fixes the issue Dan reported, I believe I don't need to resubmit my series? Cheers. Carlos