public inbox for linux-fsdevel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Hans de Goede <hdegoede@redhat.com>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH] vboxsf: Use flexible arrays for trailing string member
Date: Tue, 8 Aug 2023 14:01:55 -0700	[thread overview]
Message-ID: <202308081401.A9C03BBCF5@keescook> (raw)
In-Reply-To: <20fc56ef-6240-e86e-6d38-9278592a3b25@lwfinger.net>

On Tue, Aug 08, 2023 at 02:20:06PM -0500, Larry Finger wrote:
> On 7/26/23 16:55, Kees Cook wrote:
> > 
> > On Thu, 20 Jul 2023 08:15:06 -0700, Kees Cook wrote:
> > > The declaration of struct shfl_string used trailing fake flexible arrays
> > > for the string member. This was tripping FORTIFY_SOURCE since commit
> > > df8fc4e934c1 ("kbuild: Enable -fstrict-flex-arrays=3"). Replace the
> > > utf8 and utf16 members with actual flexible arrays, drop the unused ucs2
> > > member, and retriain a 2 byte padding to keep the structure size the same.
> > > 
> > > 
> > > [...]
> > 
> > Applied to for-linus/hardening, thanks!
> > 
> > [1/1] vboxsf: Use flexible arrays for trailing string member
> >        https://git.kernel.org/kees/c/a8f014ec6a21
> 
> Kees,
> 
> This patch has not been applied to kernel 6.5-rc5. Is there some problem?

Hi! Sorry, I was waiting for linux-next testing, and then got distracted
on Friday. I will send the PR to Linus today.

Thanks for the poke!

-Kees

-- 
Kees Cook

      reply	other threads:[~2023-08-08 21:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-20 15:15 [PATCH] vboxsf: Use flexible arrays for trailing string member Kees Cook
2023-07-25  9:00 ` Hans de Goede
2023-07-26 21:55 ` Kees Cook
2023-08-08 19:20   ` Larry Finger
2023-08-08 21:01     ` Kees Cook [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202308081401.A9C03BBCF5@keescook \
    --to=keescook@chromium.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=hdegoede@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox