From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1C9AC001E0 for ; Wed, 9 Aug 2023 07:56:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230432AbjHIH4j (ORCPT ); Wed, 9 Aug 2023 03:56:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229738AbjHIH4i (ORCPT ); Wed, 9 Aug 2023 03:56:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63CCC1736; Wed, 9 Aug 2023 00:56:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E2A226300B; Wed, 9 Aug 2023 07:56:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8D08C433C7; Wed, 9 Aug 2023 07:56:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691567797; bh=WQY/j1wRlLAF1gay3G00GCSxD4stoAKq0BiMQO5p9rY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GPCXNYecxQuiNJQEnEQp8yZaYu6iJySRdexI4jSuar+507/Y46g2iiu+kLfQa45mK T4GS+HU3tCfK0GuK5wsMw7nlsRzIgFgNOvH7tOwAFh/mRziRkxp/YgOUNN5hmE75qH qV5YEAnEboRMAqKP9/HNp84UdqdOaB/k/G/0O87YC4QRd5EC1eDLsmVQ54ib6IqPzM QxmZ5BmRDceLYLky88vlnCKQEKJI7Qgwz/bXxxvRhMYUppadwcV6UCX+gvfme2xjP1 m00ieueVSYJxe//aR9ihwdqEA95gko1caNgKGEd3OZ6CiLHREO/XSlmfcPYKLMRqua W+Hj8yMKH6OVg== Date: Wed, 9 Aug 2023 09:56:31 +0200 From: Christian Brauner To: Christoph Hellwig Cc: Al Viro , Namjae Jeon , Sungjong Seo , Theodore Ts'o , Andreas Dilger , Konstantin Komarov , "Darrick J. Wong" , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, ntfs3@lists.linux.dev, linux-xfs@vger.kernel.org Subject: Re: [PATCH 11/13] ntfs3: rename put_ntfs ntfs3_free_sbi Message-ID: <20230809-ausziehen-melken-be7ae49e204f@brauner> References: <20230808161600.1099516-1-hch@lst.de> <20230808161600.1099516-12-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230808161600.1099516-12-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Aug 08, 2023 at 09:15:58AM -0700, Christoph Hellwig wrote: > put_ntfs is a rather unconventional name for a function that frees the > sbi and associated resources. Give it a more descriptive name and drop > the duplicate name in the top of the function comment. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Reviewed-by: Christian Brauner