From: Jeff Layton <jlayton@kernel.org>
To: Christian Brauner <brauner@kernel.org>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Frank Sorenson <sorenson@redhat.com>, Jan Kara <jack@suse.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jeff Layton <jlayton@kernel.org>
Subject: [PATCH 1/2] fat: remove i_version handling from fat_update_time
Date: Thu, 10 Aug 2023 09:12:04 -0400 [thread overview]
Message-ID: <20230810-ctime-fat-v1-1-327598fd1de8@kernel.org> (raw)
In-Reply-To: <20230810-ctime-fat-v1-0-327598fd1de8@kernel.org>
commit 6bb885ecd746 (fat: add functions to update and truncate
timestamps appropriately") added an update_time routine for fat. That
patch added a section for handling the S_VERSION bit, even though FAT
doesn't enable SB_I_VERSION and the S_VERSION bit will never be set when
calling it.
Remove the section for handling S_VERSION since it's effectively dead
code, and will be problematic vs. future changes.
Cc: Frank Sorenson <sorenson@redhat.com>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
fs/fat/misc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/fat/misc.c b/fs/fat/misc.c
index ab28173348fa..37f4afb346af 100644
--- a/fs/fat/misc.c
+++ b/fs/fat/misc.c
@@ -354,9 +354,6 @@ int fat_update_time(struct inode *inode, int flags)
dirty_flags |= I_DIRTY_SYNC;
}
- if ((flags & S_VERSION) && inode_maybe_inc_iversion(inode, false))
- dirty_flags |= I_DIRTY_SYNC;
-
__mark_inode_dirty(inode, dirty_flags);
return 0;
}
--
2.41.0
next prev parent reply other threads:[~2023-08-10 13:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 13:12 [PATCH 0/2] fat: revise the FAT patches for mgtime series Jeff Layton
2023-08-10 13:12 ` Jeff Layton [this message]
2023-08-10 13:21 ` [PATCH 1/2] fat: remove i_version handling from fat_update_time Jan Kara
2023-08-10 17:31 ` OGAWA Hirofumi
2023-08-10 18:04 ` Frank Sorenson
2023-08-10 13:12 ` [PATCH 2/2] fat: make fat_update_time get its own timestamp Jeff Layton
2023-08-10 13:22 ` Jan Kara
2023-08-10 17:31 ` OGAWA Hirofumi
2023-08-10 18:05 ` Frank Sorenson
2023-08-10 13:13 ` [PATCH 0/2] fat: revise the FAT patches for mgtime series Christian Brauner
2023-08-11 7:06 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230810-ctime-fat-v1-1-327598fd1de8@kernel.org \
--to=jlayton@kernel.org \
--cc=brauner@kernel.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jack@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sorenson@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).