From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65FACC04A6A for ; Sat, 12 Aug 2023 17:29:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229772AbjHLR24 (ORCPT ); Sat, 12 Aug 2023 13:28:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbjHLR2z (ORCPT ); Sat, 12 Aug 2023 13:28:55 -0400 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C0A4F5; Sat, 12 Aug 2023 10:28:58 -0700 (PDT) Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37CHNMgH023840; Sat, 12 Aug 2023 17:28:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=jo9tUGz2NBLaraV0Fy8pU0HdtOrsA2G1C9AYSOSVFVw=; b=UzATMLkIcwO76ujXJ35usyxzag/z1bJs4pT9WZjl5ChF1M6UVCraoFVQJsAvOHa/KYg/ nE16Rv5ovH4RxdMLy9JGU3lGv00qVRi5z1JV1MSV8S6AmdYvB7iUUooMua1Hw9QzR46x erjnqlgQJ/DbCAGhtjlmvZZH6NxQUfWmMyLjMiTqpwp/pBkq0bz4D3arCaRyMg4luu5M VNpyvwDi61uZtXHPkAKSs9d5ys3vxhOJ6T+9uzjU8e8J0TRV4Kiw67TrwZLVKI+J0luv G/g9myRATa8dqd61q48xH92QGkGCoNmVD17Q/wvaKEW8kHLbawZonFslmz3K8edsT/7h gg== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3seeear28r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 12 Aug 2023 17:28:45 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 37CFF14Q017880; Sat, 12 Aug 2023 17:28:44 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3se376ma62-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 12 Aug 2023 17:28:44 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 37CHSfYB21627496 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 12 Aug 2023 17:28:41 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8572620040; Sat, 12 Aug 2023 17:28:41 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9268220049; Sat, 12 Aug 2023 17:28:40 +0000 (GMT) Received: from osiris (unknown [9.171.25.139]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTPS; Sat, 12 Aug 2023 17:28:40 +0000 (GMT) Date: Sat, 12 Aug 2023 19:28:39 +0200 From: Heiko Carstens To: Heiko Carstens Cc: Christoph Hellwig , Al Viro , Christian Brauner , Jens Axboe , Denis Efremov , Josef Bacik , Stefan Haberland , Jan Hoeppner , Vasily Gorbik , Alexander Gordeev , "Darrick J . Wong" , Chris Mason , David Sterba , linux-block@vger.kernel.org, nbd@other.debian.org, linux-s390@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 13/17] block: consolidate __invalidate_device and fsync_bdev Message-ID: <20230812172839.5133-A-hca@linux.ibm.com> References: <20230811100828.1897174-1-hch@lst.de> <20230811100828.1897174-14-hch@lst.de> <20230812105133.GA11904@lst.de> <20230812170400.11613-A-hca@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230812170400.11613-A-hca@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: eISyKqPlMJTmSSfGr2SjH_KOd-4YXOVA X-Proofpoint-ORIG-GUID: eISyKqPlMJTmSSfGr2SjH_KOd-4YXOVA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-12_17,2023-08-10_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 impostorscore=0 malwarescore=0 suspectscore=0 bulkscore=0 mlxlogscore=807 mlxscore=0 adultscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308120161 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sat, Aug 12, 2023 at 07:04:00PM +0200, Heiko Carstens wrote: > On Sat, Aug 12, 2023 at 12:51:33PM +0200, Christoph Hellwig wrote: > > The buildbot pointed out correctly (but rather late), that the special > > s390/dasd export needs a _MODULE postfix, so this will have to be > > folded in: > > > > diff --git a/block/bdev.c b/block/bdev.c > > index 2a035be7f3ee90..a20263fa27a462 100644 > > --- a/block/bdev.c > > +++ b/block/bdev.c > > @@ -967,7 +967,7 @@ void bdev_mark_dead(struct block_device *bdev, bool surprise) > > > > invalidate_bdev(bdev); > > } > > -#ifdef CONFIG_DASD > > +#ifdef CONFIG_DASD_MODULE > > This needs to be > > #if IS_ENABLED(CONFIG_DASD) > > to cover both CONFIG_DASD=y and CONFIG_DASD=m. ..but of course you only want the export for CONFIG_DASD=m. So just ignore my comment, please.