From: David Sterba <dsterba@suse.cz>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Christian Brauner <brauner@kernel.org>,
Dave Chinner <dchinner@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
David Sterba <dsterba@suse.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v1 1/1] fs/affs: Rename local toupper() to fn() to avoid confusion
Date: Thu, 17 Aug 2023 15:46:18 +0200 [thread overview]
Message-ID: <20230817134618.GT2420@suse.cz> (raw)
In-Reply-To: <20230817121217.501549-1-andriy.shevchenko@linux.intel.com>
On Thu, Aug 17, 2023 at 03:12:17PM +0300, Andy Shevchenko wrote:
> A compiler may see the collision with the toupper() defined in ctype.h:
>
> fs/affs/namei.c:159:19: warning: unused variable 'toupper' [-Wunused-variable]
> 159 | toupper_t toupper = affs_get_toupper(sb);
>
> To prevent this from happening, rename toupper local variable to fn.
>
> Initially this had been introduced by 24579a881513 ("v2.4.3.5 -> v2.4.3.6")
> in the history.git by history group.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Added to affs tree, thanks.
prev parent reply other threads:[~2023-08-17 13:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 12:12 [PATCH v1 1/1] fs/affs: Rename local toupper() to fn() to avoid confusion Andy Shevchenko
2023-08-17 13:46 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230817134618.GT2420@suse.cz \
--to=dsterba@suse.cz \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brauner@kernel.org \
--cc=dchinner@redhat.com \
--cc=dsterba@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).