linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Christian Brauner <brauner@kernel.org>
Cc: Jan Kara <jack@suse.cz>, Jens Axboe <axboe@kernel.dk>,
	Miklos Szeredi <miklos@szeredi.hu>,
	David Howells <dhowells@redhat.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org
Subject: [PATCH v3 0/7] kiocb_{start,end}_write() helpers
Date: Thu, 17 Aug 2023 17:13:30 +0300	[thread overview]
Message-ID: <20230817141337.1025891-1-amir73il@gmail.com> (raw)

Christian,

This is an attempt to consolidate the open coded lockdep fooling in
all those async io submitters into a single helper.
The idea to do that consolidation was suggested by Jan.

This re-factoring is part of a larger vfs cleanup I am doing for
fanotify permission events.  The complete series is not ready for
prime time yet, but this one patch is independent and I would love
to get it reviewed/merged a head of the rest.

This v3 series addresses the review comments of Jens on v2 [1].

Thanks,
Amir.

Changes since v2:
- Split patches to helpers and use helpers per caller (Jens)
- Drop IOCB_WRITE_STARTED flag

Changes since v1:
- Leave ISREG checks in callers (Jens)
- Leave setting IOCB_WRITE flag in callers

[1] https://lore.kernel.org/linux-fsdevel/20230816085439.894112-1-amir73il@gmail.com/

Amir Goldstein (7):
  io_uring: rename kiocb_end_write() local helper
  fs: add kerneldoc to file_{start,end}_write() helpers
  fs: create kiocb_{start,end}_write() helpers
  io_uring: use kiocb_{start,end}_write() helpers
  aio: use kiocb_{start,end}_write() helpers
  ovl: use kiocb_{start,end}_write() helpers
  cachefiles: use kiocb_{start,end}_write() helpers

 fs/aio.c            | 20 +++---------------
 fs/cachefiles/io.c  | 16 +++-----------
 fs/overlayfs/file.c | 10 ++-------
 include/linux/fs.h  | 51 ++++++++++++++++++++++++++++++++++++++++++++-
 io_uring/rw.c       | 33 ++++++++---------------------
 5 files changed, 67 insertions(+), 63 deletions(-)

-- 
2.34.1


             reply	other threads:[~2023-08-17 14:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17 14:13 Amir Goldstein [this message]
2023-08-17 14:13 ` [PATCH v3 1/7] io_uring: rename kiocb_end_write() local helper Amir Goldstein
2023-08-17 14:46   ` Jan Kara
2023-08-17 14:13 ` [PATCH v3 2/7] fs: add kerneldoc to file_{start,end}_write() helpers Amir Goldstein
2023-08-17 14:46   ` Jan Kara
2023-08-17 14:13 ` [PATCH v3 3/7] fs: create kiocb_{start,end}_write() helpers Amir Goldstein
2023-08-17 14:47   ` Jan Kara
2023-08-17 14:13 ` [PATCH v3 4/7] io_uring: use " Amir Goldstein
2023-08-21 12:27   ` Jan Kara
2023-08-17 14:13 ` [PATCH v3 5/7] aio: " Amir Goldstein
2023-08-17 14:48   ` Jan Kara
2023-08-17 14:13 ` [PATCH v3 6/7] ovl: " Amir Goldstein
2023-08-17 14:49   ` Jan Kara
2023-08-17 14:13 ` [PATCH v3 7/7] cachefiles: " Amir Goldstein
2023-08-17 14:50   ` Jan Kara
2023-08-17 14:56 ` [PATCH v3 0/7] " Christian Brauner
2023-08-21 11:35   ` Amir Goldstein
2023-08-21 12:27     ` Jan Kara
2023-08-21 15:30 ` Christian Brauner
2023-08-21 16:37 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230817141337.1025891-1-amir73il@gmail.com \
    --to=amir73il@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=brauner@kernel.org \
    --cc=dhowells@redhat.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).