linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Christian Brauner <brauner@kernel.org>
Cc: Jan Kara <jack@suse.cz>, Jens Axboe <axboe@kernel.dk>,
	Miklos Szeredi <miklos@szeredi.hu>,
	David Howells <dhowells@redhat.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org
Subject: [PATCH v3 5/7] aio: use kiocb_{start,end}_write() helpers
Date: Thu, 17 Aug 2023 17:13:35 +0300	[thread overview]
Message-ID: <20230817141337.1025891-6-amir73il@gmail.com> (raw)
In-Reply-To: <20230817141337.1025891-1-amir73il@gmail.com>

Use helpers instead of the open coded dance to silence lockdep warnings.

Suggested-by: Jan Kara <jack@suse.cz>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
 fs/aio.c | 20 +++-----------------
 1 file changed, 3 insertions(+), 17 deletions(-)

diff --git a/fs/aio.c b/fs/aio.c
index 77e33619de40..b3174da80ff6 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -1447,13 +1447,8 @@ static void aio_complete_rw(struct kiocb *kiocb, long res)
 	if (kiocb->ki_flags & IOCB_WRITE) {
 		struct inode *inode = file_inode(kiocb->ki_filp);
 
-		/*
-		 * Tell lockdep we inherited freeze protection from submission
-		 * thread.
-		 */
 		if (S_ISREG(inode->i_mode))
-			__sb_writers_acquired(inode->i_sb, SB_FREEZE_WRITE);
-		file_end_write(kiocb->ki_filp);
+			kiocb_end_write(kiocb);
 	}
 
 	iocb->ki_res.res = res;
@@ -1581,17 +1576,8 @@ static int aio_write(struct kiocb *req, const struct iocb *iocb,
 		return ret;
 	ret = rw_verify_area(WRITE, file, &req->ki_pos, iov_iter_count(&iter));
 	if (!ret) {
-		/*
-		 * Open-code file_start_write here to grab freeze protection,
-		 * which will be released by another thread in
-		 * aio_complete_rw().  Fool lockdep by telling it the lock got
-		 * released so that it doesn't complain about the held lock when
-		 * we return to userspace.
-		 */
-		if (S_ISREG(file_inode(file)->i_mode)) {
-			sb_start_write(file_inode(file)->i_sb);
-			__sb_writers_release(file_inode(file)->i_sb, SB_FREEZE_WRITE);
-		}
+		if (S_ISREG(file_inode(file)->i_mode))
+			kiocb_start_write(req);
 		req->ki_flags |= IOCB_WRITE;
 		aio_rw_done(req, call_write_iter(file, req, &iter));
 	}
-- 
2.34.1


  parent reply	other threads:[~2023-08-17 14:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17 14:13 [PATCH v3 0/7] kiocb_{start,end}_write() helpers Amir Goldstein
2023-08-17 14:13 ` [PATCH v3 1/7] io_uring: rename kiocb_end_write() local helper Amir Goldstein
2023-08-17 14:46   ` Jan Kara
2023-08-17 14:13 ` [PATCH v3 2/7] fs: add kerneldoc to file_{start,end}_write() helpers Amir Goldstein
2023-08-17 14:46   ` Jan Kara
2023-08-17 14:13 ` [PATCH v3 3/7] fs: create kiocb_{start,end}_write() helpers Amir Goldstein
2023-08-17 14:47   ` Jan Kara
2023-08-17 14:13 ` [PATCH v3 4/7] io_uring: use " Amir Goldstein
2023-08-21 12:27   ` Jan Kara
2023-08-17 14:13 ` Amir Goldstein [this message]
2023-08-17 14:48   ` [PATCH v3 5/7] aio: " Jan Kara
2023-08-17 14:13 ` [PATCH v3 6/7] ovl: " Amir Goldstein
2023-08-17 14:49   ` Jan Kara
2023-08-17 14:13 ` [PATCH v3 7/7] cachefiles: " Amir Goldstein
2023-08-17 14:50   ` Jan Kara
2023-08-17 14:56 ` [PATCH v3 0/7] " Christian Brauner
2023-08-21 11:35   ` Amir Goldstein
2023-08-21 12:27     ` Jan Kara
2023-08-21 15:30 ` Christian Brauner
2023-08-21 16:37 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230817141337.1025891-6-amir73il@gmail.com \
    --to=amir73il@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=brauner@kernel.org \
    --cc=dhowells@redhat.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).