From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F35EEC41513 for ; Thu, 17 Aug 2023 16:59:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353771AbjHQQ6n (ORCPT ); Thu, 17 Aug 2023 12:58:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353832AbjHQQ6h (ORCPT ); Thu, 17 Aug 2023 12:58:37 -0400 Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3FB22D73 for ; Thu, 17 Aug 2023 09:58:35 -0700 (PDT) Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-58c55d408daso311637b3.2 for ; Thu, 17 Aug 2023 09:58:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20221208.gappssmtp.com; s=20221208; t=1692291515; x=1692896315; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XPfbwT5lP7oF8sr3fFtMy1piLFYVDYQGf7F5OxaBsLA=; b=kmpvmV/nSoSRtn95qai/zi6Dx895sII/IQfkW9Kr9r1MgnYKy3aywgZV0QEGPAUqKQ saGC8aplb5hyE4VPboitoorcJnWfTJKvopTUP73FVyqUmbYXtq3TV8jS2lQxER0NfqnV +KET1YClH0Na4lOVn1y4mdVSo+AmIptIgx3N6ScM5ubbiaKgroMBXcw6581oXAzHT4fo 3HaYAgMCZzJGRn1Mm2lhZtWJVpaxrge9/fzB09YOaJd2gBzk6j1y4pKtG8Eg0D6r0hxG SyozquNG9Y3O4oI7riQG7PKNt+u1tZwIgHOrNVsZkQfH5hdd0uK3hrjA/kI37M+dhFVc AhHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692291515; x=1692896315; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XPfbwT5lP7oF8sr3fFtMy1piLFYVDYQGf7F5OxaBsLA=; b=kd9tHeAmZ7PuGYzPOgVk7d+ubIll2JuDsLVx6YxaRzSOUsGXNzynWAYDiEET5T6mJx 0qF+Et/DgaC8WlVhItsbYPeVZ/5AhCF148escQH1dtw8cal1PzNH3OAdvA3emxCJ5bBv fn/sXKJJT1VVqpblyG46xS67GDHnr4mfnk7OzX+jotko8TuwngvXVei0iH7q27GwvLY0 4QxofeOguBOveL4QH6GgB9Ofdb1cuibreCuWAP22oaKCnlR0OnwfNy/9bzLDHdk+2D3V 5eMNG/jDmcezBYlEn6dhM6IbLGMxAly3H0Z2ywm//lTEFYBOtZOKJQM3gyr9uVBA5h5s ooJA== X-Gm-Message-State: AOJu0YxkPCB73UKjqlJ4hrrF4oWVidTIyxDnWdI5nhnU4KoMwZda3P4u KR2/0PRWnTFXYTFMv2rWS8N+LA== X-Google-Smtp-Source: AGHT+IHrMoQN21D09izpb0BbTbcUmonBnGXyP0oQnb9jFxMr0xhuSY6w3oPmCIaq7D5DJAA6IHa+3Q== X-Received: by 2002:a81:6946:0:b0:589:9ed0:5178 with SMTP id e67-20020a816946000000b005899ed05178mr6183683ywc.13.1692291515120; Thu, 17 Aug 2023 09:58:35 -0700 (PDT) Received: from localhost (cpe-76-182-20-124.nc.res.rr.com. [76.182.20.124]) by smtp.gmail.com with ESMTPSA id k185-20020a0dc8c2000000b005773ca61111sm4727516ywd.42.2023.08.17.09.58.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Aug 2023 09:58:34 -0700 (PDT) Date: Thu, 17 Aug 2023 12:58:33 -0400 From: Josef Bacik To: "Guilherme G. Piccoli" Cc: linux-btrfs@vger.kernel.org, clm@fb.com, dsterba@suse.com, linux-fsdevel@vger.kernel.org, kernel@gpiccoli.net, kernel-dev@igalia.com, anand.jain@oracle.com, david@fromorbit.com, kreijack@libero.it, johns@valvesoftware.com, ludovico.denittis@collabora.com, quwenruo.btrfs@gmx.com, wqu@suse.com, vivek@collabora.com Subject: Re: [PATCH 2/3] btrfs: Introduce the single-dev feature Message-ID: <20230817165833.GA2935315@perftesting> References: <20230803154453.1488248-1-gpiccoli@igalia.com> <20230803154453.1488248-3-gpiccoli@igalia.com> <20230817154127.GB2934386@perftesting> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Aug 17, 2023 at 01:20:55PM -0300, Guilherme G. Piccoli wrote: > On 17/08/2023 12:41, Josef Bacik wrote: > >> [...] > >> + pr_info("BTRFS: virtual fsid (%pU) set for SINGLE_DEV device %s (real fsid %pU)\n", > >> + disk_super->fsid, path, disk_super->metadata_uuid); > > > > I think just > > > > btrfs_info(NULL, "virtual fsid....") > > > > is fine here. > > > > So just for my full understanding, do you think we shouldn't show the > real fsid here, but keep showing the virtual one, right? Or you prefer > we literally show "virtual fsid...."? Oh no sorry, just swap pr_info for btrfs_info, and keep the rest the same, so btrfs_info("virtual fsid (%pU) set for SINGLE_DEV device %s (real fsid %pU)\n", disk_super->fsid, path, disk_super->metadata_uuid); thanks, Josef