From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DC27C83F14 for ; Tue, 29 Aug 2023 12:52:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235600AbjH2Mve (ORCPT ); Tue, 29 Aug 2023 08:51:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235615AbjH2MvZ (ORCPT ); Tue, 29 Aug 2023 08:51:25 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A71769D for ; Tue, 29 Aug 2023 05:51:22 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 4AA1D6732D; Tue, 29 Aug 2023 14:51:19 +0200 (CEST) Date: Tue, 29 Aug 2023 14:51:18 +0200 From: Christoph Hellwig To: Christian Brauner Cc: Jan Kara , Christoph Hellwig , linux-fsdevel@vger.kernel.org Subject: Re: mtd Message-ID: <20230829125118.GA24767@lst.de> References: <20230829-weitab-lauwarm-49c40fc85863@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230829-weitab-lauwarm-49c40fc85863@brauner> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Aug 29, 2023 at 01:46:20PM +0200, Christian Brauner wrote: > Something like the following might already be enough (IT'S A DRAFT, AND > UNTESTED, AND PROBABLY BROKEN)? It's probably the right thing conceptually, but it will also need the SB_I_RETIRED from test_bdev_super_fc or even just reuse test_bdev_super_fc after that's been renamed to be more generic. In fact I've been wondering for a while why we even support the magic keyed get_super - if it allocates a new super it should also have a new dev_t. So IMHO we should stop playing stupid tricks with keys and just declare the dev_t the key after doing all the required work for it, that is allocating the per-instance anon dev_t in the caller.