From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86215C83F1B for ; Wed, 30 Aug 2023 01:25:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241552AbjH3BYn (ORCPT ); Tue, 29 Aug 2023 21:24:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237222AbjH3BY3 (ORCPT ); Tue, 29 Aug 2023 21:24:29 -0400 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A42FE0; Tue, 29 Aug 2023 18:24:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UGL8Hs7wie/83TbDi9sHxBsPaDb/+1IP8lK74uZbCKw=; b=VMCLMK1iXxNHLo2tyoSLb1HI/I ygrNcHqe5LWzcSOicXKiXv7+aZW1BJ7dB0vjqMCV0MnziRQDnoZOz3XgmiNQiiDnA13PUlmOVrxc4 WpSk9x7uA8R3KciGWN7qJ88utnJ3QSHSvYKWfoJJvhO0U1H1/cqwYZYmtvld8BDA8iqcXv8CBaGId erqQdPcYkjIFz/hBJqwMuB/rDK2BOMTdgnlCwnIMFpdDxv6wkG8Wn7rLsnAYsC5D7sc1BRtVulXjw RcKjf3m9ODmy0yW/y+LgeKEyGIU6PCqX4XrC83Co4MtcnJcvY9SuxDXgB2k0Ps8NGdX3ExJB41/fI ibsynONQ==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1qb9v5-001yGw-2Z; Wed, 30 Aug 2023 01:22:55 +0000 Date: Wed, 30 Aug 2023 02:22:55 +0100 From: Al Viro To: Jeff Layton Cc: Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Christian Brauner , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , "Darrick J. Wong" , Dave Chinner , Anthony Iliopoulos , v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v6 1/7] fs: pass the request_mask to generic_fillattr Message-ID: <20230830012255.GC3390869@ZenIV> References: <20230725-mgctime-v6-0-a794c2b7abca@kernel.org> <20230725-mgctime-v6-1-a794c2b7abca@kernel.org> <20230829224454.GA461907@ZenIV> <20230830000221.GB3390869@ZenIV> <1005e30582138e203a99f49564e2ef244b8d56aa.camel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1005e30582138e203a99f49564e2ef244b8d56aa.camel@kernel.org> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Aug 29, 2023 at 08:43:31PM -0400, Jeff Layton wrote: > On Wed, 2023-08-30 at 01:02 +0100, Al Viro wrote: > > On Tue, Aug 29, 2023 at 06:58:47PM -0400, Jeff Layton wrote: > > > On Tue, 2023-08-29 at 23:44 +0100, Al Viro wrote: > > > > On Tue, Jul 25, 2023 at 10:58:14AM -0400, Jeff Layton wrote: > > > > > generic_fillattr just fills in the entire stat struct indiscriminately > > > > > today, copying data from the inode. There is at least one attribute > > > > > (STATX_CHANGE_COOKIE) that can have side effects when it is reported, > > > > > and we're looking at adding more with the addition of multigrain > > > > > timestamps. > > > > > > > > > > Add a request_mask argument to generic_fillattr and have most callers > > > > > just pass in the value that is passed to getattr. Have other callers > > > > > (e.g. ksmbd) just pass in STATX_BASIC_STATS. Also move the setting of > > > > > STATX_CHANGE_COOKIE into generic_fillattr. > > > > > > > > Out of curiosity - how much PITA would it be to put request_mask into > > > > kstat? Set it in vfs_getattr_nosec() (and those get_file_..._info() > > > > on smbd side) and don't bother with that kind of propagation boilerplate > > > > - just have generic_fillattr() pick it there... > > > > > > > > Reduces the patchset size quite a bit... > > > > > > It could be done. To do that right, I think we'd want to drop > > > request_mask from the ->getattr prototype as well and just have > > > everything use the mask in the kstat. > > > > > > I don't think it'd reduce the size of the patchset in any meaningful > > > way, but it might make for a more sensible API over the long haul. > > > > ->getattr() prototype change would be decoupled from that - for your > > patchset you'd only need the field addition + setting in vfs_getattr_nosec() > > (and possibly in ksmbd), with the remainders of both series being > > independent from each other. > > > > What I suggest is > > > > branchpoint -> field addition (trivial commit) -> argument removal > > | > > V > > your series, starting with "use stat->request_mask in generic_fillattr()" > > > > Total size would be about the same, but it would be easier to follow > > the less trivial part of that. Nothing in your branch downstream of > > that touches any ->getattr() instances, so it should have no > > conflicts with the argument removal side of things. > > The only problem with this plan is that Linus has already merged this. > I've no issue with adding the request_mask to the kstat and removing it > as a separate parameter elsewhere, but I think we'll need to do it on > top of what's already been merged. D'oh... My apologies; I'll do a branch on top of that (and rebase on top of -rc1 once the window closes).