From: Al Viro <viro@zeniv.linux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: Christian Brauner <brauner@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Paul Moore <paul@paul-moore.com>,
Stephen Smalley <stephen.smalley.work@gmail.com>,
Eric Paris <eparis@parisplace.org>,
linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org,
selinux@vger.kernel.org
Subject: Re: [PATCH 3/4] selinuxfs: free sb->s_fs_info after shutting down the super block
Date: Thu, 31 Aug 2023 07:33:49 +0100 [thread overview]
Message-ID: <20230831063349.GF3390869@ZenIV> (raw)
In-Reply-To: <20230831053157.256319-4-hch@lst.de>
On Thu, Aug 31, 2023 at 07:31:56AM +0200, Christoph Hellwig wrote:
> sb->s_fs_info can only be safely freed after generic_shutdown_super was
> called and all access to the super_block has stopped.
>
> Thus only free the private data after calling kill_litter_super, which
> calls generic_shutdown_super internally.
Same as for ramfs, AFAICS.
> Also remove the duplicate freeing in the sel_fill_super error path given
> that ->kіll_sb is also called on ->fill_super failure.
Reasonable cleanup, that.
next prev parent reply other threads:[~2023-08-31 6:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 5:31 sb->s_fs_info freeing fixes Christoph Hellwig
2023-08-31 5:31 ` [PATCH 1/4] ramfs: free sb->s_fs_info after shutting down the super block Christoph Hellwig
2023-08-31 6:25 ` Al Viro
2023-08-31 5:31 ` [PATCH 2/4] devpts: " Christoph Hellwig
2023-08-31 6:31 ` Al Viro
2023-08-31 5:31 ` [PATCH 3/4] selinuxfs: " Christoph Hellwig
2023-08-31 6:33 ` Al Viro [this message]
2023-08-31 5:31 ` [PATCH 4/4] hypfs: " Christoph Hellwig
2023-08-31 6:37 ` Al Viro
2023-08-31 10:20 ` sb->s_fs_info freeing fixes Christian Brauner
2023-08-31 10:29 ` Christian Brauner
2023-08-31 12:36 ` Christoph Hellwig
2023-08-31 13:11 ` Christian Brauner
2023-08-31 14:38 ` Paul Moore
2023-08-31 14:39 ` Christoph Hellwig
2023-08-31 14:49 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230831063349.GF3390869@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=agordeev@linux.ibm.com \
--cc=brauner@kernel.org \
--cc=eparis@parisplace.org \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).