From: "Darrick J. Wong" <djwong@kernel.org>
To: Christian Brauner <brauner@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
viro@zeniv.linux.org.uk, axboe@kernel.dk,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
syzbot+4a08ffdf3667b36650a1@syzkaller.appspotmail.com
Subject: Re: [PATCH] iomap: handle error conditions more gracefully in iomap_to_bh
Date: Wed, 6 Sep 2023 07:54:39 -0700 [thread overview]
Message-ID: <20230906145439.GC28160@frogsfrogsfrogs> (raw)
In-Reply-To: <20230906-waagrecht-schwester-f3d460199ae5@brauner>
On Wed, Sep 06, 2023 at 04:30:39PM +0200, Christian Brauner wrote:
> On Tue, Sep 05, 2023 at 08:39:53AM -0700, Darrick J. Wong wrote:
> > On Tue, Sep 05, 2023 at 02:41:20PM +0200, Christoph Hellwig wrote:
> > > iomap_to_bh currently BUG()s when the passed in block number is not
> > > in the iomap. For file systems that have proper synchronization this
> > > should never happen and so far hasn't in mainline, but for block devices
> > > size changes aren't fully synchronized against ongoing I/O. Instead
> > > of BUG()ing in this case, return -EIO to the caller, which already has
> > > proper error handling. While we're at it, also return -EIO for an
> > > unknown iomap state instead of returning garbage.
> > >
> > > Fixes: 487c607df790 ("block: use iomap for writes to block devices")
> > > Reported-by: syzbot+4a08ffdf3667b36650a1@syzkaller.appspotmail.com
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > > ---
> >
> > Looks like a good improvement. Who should this go through, me (iomap)
> > or viro/brauner (vfs*) ?
> >
> > Reviewed-by: Darrick J. Wong <djwong@kernel.org>
> >
> > (lol is email down again?)
>
> I can grab it if you want.
> What's up with email? Did you send this a long time ago?
This reply I only sent yesterday, but last week Konstantin reported that
gmail was DDOSing vger again, and then I didn't get any emails for 4
days.
On the bright side I did have a good sprint for online fsck. :)
--D
next prev parent reply other threads:[~2023-09-06 14:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 12:41 [PATCH] iomap: handle error conditions more gracefully in iomap_to_bh Christoph Hellwig
2023-09-05 15:39 ` Darrick J. Wong
2023-09-05 15:53 ` Christoph Hellwig
2023-09-06 14:30 ` Christian Brauner
2023-09-06 14:54 ` Darrick J. Wong [this message]
2023-09-06 1:18 ` Damien Le Moal
2023-09-06 9:26 ` Hannes Reinecke
2023-09-06 14:31 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230906145439.GC28160@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=syzbot+4a08ffdf3667b36650a1@syzkaller.appspotmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).