From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73F7EEE14A0 for ; Wed, 6 Sep 2023 14:55:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240491AbjIFOzU (ORCPT ); Wed, 6 Sep 2023 10:55:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238421AbjIFOzT (ORCPT ); Wed, 6 Sep 2023 10:55:19 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCE1C1990; Wed, 6 Sep 2023 07:54:47 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55710C433C8; Wed, 6 Sep 2023 14:54:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694012080; bh=x4KcQuBfQvpvFpE5R4CSNGNTjDDTjo0HmHdevrDUcco=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gX+CqMYTkuJHb/XfQoCXfubeJYWMqL00Os53jov/lcE/IiXXVIU8fW2Beh/RS1Ya+ Rpkh9Z2Cu4xBxs5pWzbIrMwE88FcfSlv1B0hhQLk8XzVKfeGQCvm/Tg4GsiZnF5YcG ik+BrcCQ5lXb1oFItOuX9EKCocA4Bg8yCQ5ESpAqY94qvhx+8Gplmy7ho1E3gd4KUT d4dPEoNwNnasm4uHT9TakHoAsFgwJJkUyChv6D3CsqwsaXN1+GNeI1rxxqg2LM3gi9 ppSuAql56pVN33SJE6TPZ6FPsn0So0yjh2gZ6ryg6Aqs5xUkESCBaS2dtsHHW4dzpj LJwIUxxoqM8ng== Date: Wed, 6 Sep 2023 07:54:39 -0700 From: "Darrick J. Wong" To: Christian Brauner Cc: Christoph Hellwig , viro@zeniv.linux.org.uk, axboe@kernel.dk, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, syzbot+4a08ffdf3667b36650a1@syzkaller.appspotmail.com Subject: Re: [PATCH] iomap: handle error conditions more gracefully in iomap_to_bh Message-ID: <20230906145439.GC28160@frogsfrogsfrogs> References: <20230905124120.325518-1-hch@lst.de> <20230905153953.GG28202@frogsfrogsfrogs> <20230906-waagrecht-schwester-f3d460199ae5@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230906-waagrecht-schwester-f3d460199ae5@brauner> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Sep 06, 2023 at 04:30:39PM +0200, Christian Brauner wrote: > On Tue, Sep 05, 2023 at 08:39:53AM -0700, Darrick J. Wong wrote: > > On Tue, Sep 05, 2023 at 02:41:20PM +0200, Christoph Hellwig wrote: > > > iomap_to_bh currently BUG()s when the passed in block number is not > > > in the iomap. For file systems that have proper synchronization this > > > should never happen and so far hasn't in mainline, but for block devices > > > size changes aren't fully synchronized against ongoing I/O. Instead > > > of BUG()ing in this case, return -EIO to the caller, which already has > > > proper error handling. While we're at it, also return -EIO for an > > > unknown iomap state instead of returning garbage. > > > > > > Fixes: 487c607df790 ("block: use iomap for writes to block devices") > > > Reported-by: syzbot+4a08ffdf3667b36650a1@syzkaller.appspotmail.com > > > Signed-off-by: Christoph Hellwig > > > --- > > > > Looks like a good improvement. Who should this go through, me (iomap) > > or viro/brauner (vfs*) ? > > > > Reviewed-by: Darrick J. Wong > > > > (lol is email down again?) > > I can grab it if you want. > What's up with email? Did you send this a long time ago? This reply I only sent yesterday, but last week Konstantin reported that gmail was DDOSing vger again, and then I didn't get any emails for 4 days. On the bright side I did have a good sprint for online fsck. :) --D