From: Christian Brauner <brauner@kernel.org>
To: Reuben Hawkins <reubenhwk@gmail.com>
Cc: Christian Brauner <brauner@kernel.org>,
amir73il@gmail.com, mszeredi@redhat.com, willy@infradead.org,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] vfs: fix readahead(2) on block devices
Date: Mon, 11 Sep 2023 15:51:15 +0200 [thread overview]
Message-ID: <20230911-plakat-machwerk-7cb027631a5e@brauner> (raw)
In-Reply-To: <20230911114713.25625-1-reubenhwk@gmail.com>
On Mon, 11 Sep 2023 06:47:13 -0500, Reuben Hawkins wrote:
> Readahead was factored to call generic_fadvise. That refactor added an
> S_ISREG restriction which broke readahead on block devices.
>
> This change removes the S_ISREG restriction to fix block device readahead.
> The change also means that readahead will return -ESPIPE on FIFO files
> instead of -EINVAL.
>
> [...]
Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc
[1/1] vfs: fix readahead(2) on block devices
https://git.kernel.org/vfs/vfs/c/d05ad99006a6
next prev parent reply other threads:[~2023-09-11 20:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 11:47 [PATCH v2] vfs: fix readahead(2) on block devices Reuben Hawkins
2023-09-11 13:23 ` Amir Goldstein
2023-09-11 13:51 ` Christian Brauner [this message]
2023-09-14 8:35 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230911-plakat-machwerk-7cb027631a5e@brauner \
--to=brauner@kernel.org \
--cc=amir73il@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=reubenhwk@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).