linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Andrii Nakryiko <andrii@kernel.org>, bpf@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	linux-fsdevel@vger.kernel.org,
	linux-security-module@vger.kernel.org, keescook@chromium.org,
	brauner@kernel.org, lennart@poettering.net, kernel-team@meta.com,
	sargun@sargun.me
Subject: Re: [PATCH v4 bpf-next 06/12] bpf: take into account BPF token when fetching helper protos
Date: Thu, 14 Sep 2023 02:41:26 +0800	[thread overview]
Message-ID: <202309140202.lwVDn4bK-lkp@intel.com> (raw)
In-Reply-To: <20230912212906.3975866-7-andrii@kernel.org>

Hi Andrii,

kernel test robot noticed the following build errors:

[auto build test ERROR on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Andrii-Nakryiko/bpf-add-BPF-token-delegation-mount-options-to-BPF-FS/20230913-053240
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link:    https://lore.kernel.org/r/20230912212906.3975866-7-andrii%40kernel.org
patch subject: [PATCH v4 bpf-next 06/12] bpf: take into account BPF token when fetching helper protos
config: i386-randconfig-r015-20230913 (https://download.01.org/0day-ci/archive/20230914/202309140202.lwVDn4bK-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230914/202309140202.lwVDn4bK-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309140202.lwVDn4bK-lkp@intel.com/

All errors (new ones prefixed by >>):

>> net/core/filter.c:11721:7: error: call to undeclared function 'bpf_token_capable'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           if (!bpf_token_capable(prog->aux->token, CAP_PERFMON))
                ^
   1 error generated.


vim +/bpf_token_capable +11721 net/core/filter.c

 11687	
 11688	static const struct bpf_func_proto *
 11689	bpf_sk_base_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog)
 11690	{
 11691		const struct bpf_func_proto *func;
 11692	
 11693		switch (func_id) {
 11694		case BPF_FUNC_skc_to_tcp6_sock:
 11695			func = &bpf_skc_to_tcp6_sock_proto;
 11696			break;
 11697		case BPF_FUNC_skc_to_tcp_sock:
 11698			func = &bpf_skc_to_tcp_sock_proto;
 11699			break;
 11700		case BPF_FUNC_skc_to_tcp_timewait_sock:
 11701			func = &bpf_skc_to_tcp_timewait_sock_proto;
 11702			break;
 11703		case BPF_FUNC_skc_to_tcp_request_sock:
 11704			func = &bpf_skc_to_tcp_request_sock_proto;
 11705			break;
 11706		case BPF_FUNC_skc_to_udp6_sock:
 11707			func = &bpf_skc_to_udp6_sock_proto;
 11708			break;
 11709		case BPF_FUNC_skc_to_unix_sock:
 11710			func = &bpf_skc_to_unix_sock_proto;
 11711			break;
 11712		case BPF_FUNC_skc_to_mptcp_sock:
 11713			func = &bpf_skc_to_mptcp_sock_proto;
 11714			break;
 11715		case BPF_FUNC_ktime_get_coarse_ns:
 11716			return &bpf_ktime_get_coarse_ns_proto;
 11717		default:
 11718			return bpf_base_func_proto(func_id, prog);
 11719		}
 11720	
 11721		if (!bpf_token_capable(prog->aux->token, CAP_PERFMON))
 11722			return NULL;
 11723	
 11724		return func;
 11725	}
 11726	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2023-09-13 18:42 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-12 21:28 [PATCH v4 bpf-next 00/12] BPF token and BPF FS-based delegation Andrii Nakryiko
2023-09-12 21:28 ` [PATCH v4 bpf-next 01/12] bpf: add BPF token delegation mount options to BPF FS Andrii Nakryiko
2023-09-12 21:28 ` [PATCH v4 bpf-next 02/12] bpf: introduce BPF token object Andrii Nakryiko
2023-09-12 21:46   ` Andrii Nakryiko
2023-09-13 21:46   ` [PATCH v4 2/12] " Paul Moore
2023-09-14 17:31     ` Andrii Nakryiko
2023-09-15  0:55       ` Paul Moore
2023-09-15 20:59         ` Andrii Nakryiko
2023-09-21 22:18           ` Paul Moore
2023-09-22  9:27             ` Paul Moore
2023-09-22 22:35             ` Andrii Nakryiko
2023-09-26 21:32               ` Paul Moore
2023-10-10 21:19               ` Paul Moore
2023-10-12  0:32                 ` Andrii Nakryiko
2023-09-12 21:28 ` [PATCH v4 bpf-next 03/12] bpf: add BPF token support to BPF_MAP_CREATE command Andrii Nakryiko
2023-09-12 21:28 ` [PATCH v4 bpf-next 04/12] bpf: add BPF token support to BPF_BTF_LOAD command Andrii Nakryiko
2023-09-12 21:28 ` [PATCH v4 bpf-next 05/12] bpf: add BPF token support to BPF_PROG_LOAD command Andrii Nakryiko
2023-09-12 21:29 ` [PATCH v4 bpf-next 06/12] bpf: take into account BPF token when fetching helper protos Andrii Nakryiko
2023-09-13  9:45   ` kernel test robot
2023-09-13 18:41   ` kernel test robot [this message]
2023-09-12 21:29 ` [PATCH v4 bpf-next 07/12] bpf: consistenly use BPF token throughout BPF verifier logic Andrii Nakryiko
2023-09-13 22:15   ` kernel test robot
2023-09-12 21:29 ` [PATCH v4 bpf-next 08/12] libbpf: add bpf_token_create() API Andrii Nakryiko
2023-09-12 21:42   ` Andrii Nakryiko
2023-09-12 21:29 ` [PATCH v4 bpf-next 09/12] libbpf: add BPF token support to bpf_map_create() API Andrii Nakryiko
2023-09-12 21:29 ` [PATCH v4 bpf-next 10/12] libbpf: add BPF token support to bpf_btf_load() API Andrii Nakryiko
2023-09-12 21:29 ` [PATCH v4 bpf-next 11/12] libbpf: add BPF token support to bpf_prog_load() API Andrii Nakryiko
2023-09-12 21:29 ` [PATCH v4 bpf-next 12/12] selftests/bpf: add BPF token-enabled tests Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202309140202.lwVDn4bK-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brauner@kernel.org \
    --cc=keescook@chromium.org \
    --cc=kernel-team@meta.com \
    --cc=lennart@poettering.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=sargun@sargun.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).