From: Christian Brauner <brauner@kernel.org>
To: Max Kellermann <max.kellermann@ionos.com>
Cc: Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk, howells@redhat.com
Subject: Re: [PATCH 1/4] pipe: reduce padding in struct pipe_inode_info
Date: Thu, 21 Sep 2023 17:39:36 +0200 [thread overview]
Message-ID: <20230921-witzig-magen-54a20bb51111@brauner> (raw)
In-Reply-To: <20230921075755.1378787-1-max.kellermann@ionos.com>
On Thu, 21 Sep 2023 09:57:52 +0200, Max Kellermann wrote:
> This has no effect on 64 bit because there are 10 32-bit integers
> surrounding the two bools, but on 32 bit architectures, this reduces
> the struct size by 4 bytes by merging the two bools into one word.
>
>
I've massaged the last commit a bit and moved that bit into a helper
instead of indentorama in pipe_write(). keyutils watchqueue tests and
LTP pipe and watch queue tests pass without regressions.
---
Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc
[1/4] pipe: reduce padding in struct pipe_inode_info
https://git.kernel.org/vfs/vfs/c/5ba6d9b6d526
[2/4] fs/pipe: move check to pipe_has_watch_queue()
https://git.kernel.org/vfs/vfs/c/7084dde72592
[3/4] fs/pipe: remove unnecessary spinlock from pipe_write()
https://git.kernel.org/vfs/vfs/c/b9e8c77cad52
[4/4] fs/pipe: use spinlock in pipe_read() only if there is a watch_queue
https://git.kernel.org/vfs/vfs/c/4c280825d39c
prev parent reply other threads:[~2023-09-21 21:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 7:57 [PATCH 1/4] pipe: reduce padding in struct pipe_inode_info Max Kellermann
2023-09-21 7:57 ` [PATCH 2/4] fs/pipe: move check to pipe_has_watch_queue() Max Kellermann
2023-09-21 7:57 ` [PATCH 3/4] fs/pipe: remove unnecessary spinlock from pipe_write() Max Kellermann
2023-09-21 7:57 ` [PATCH 4/4] fs/pipe: use spinlock in pipe_read() only if there is a watch_queue Max Kellermann
2023-09-21 15:39 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230921-witzig-magen-54a20bb51111@brauner \
--to=brauner@kernel.org \
--cc=howells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max.kellermann@ionos.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).