* [PATCH] fuse: pass ATTR_KILL_SUID/ATTR_KILL_SGID mode bits to user space
@ 2023-09-21 2:24 xiubli
2023-10-07 7:50 ` Xiubo Li
0 siblings, 1 reply; 2+ messages in thread
From: xiubli @ 2023-09-21 2:24 UTC (permalink / raw)
To: miklos; +Cc: linux-fsdevel, linux-kernel, Xiubo Li
From: Xiubo Li <xiubli@redhat.com>
Such as for the xfstest-dev's generic/684 test case it will clear
suid and sgid if the fallocate request is commit by an unprivileged
user.
We need to pass the ATTR_KILL_SUID/ATTR_KILL_SGID flags to userspace.
Signed-off-by: Xiubo Li <xiubli@redhat.com>
---
fs/fuse/dir.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index f67bef9d83c4..73dcf54efbff 100644
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -1938,11 +1938,11 @@ static int fuse_setattr(struct mnt_idmap *idmap, struct dentry *entry,
attr->ia_mode = inode->i_mode;
if (inode->i_mode & S_ISUID) {
- attr->ia_valid |= ATTR_MODE;
+ attr->ia_valid |= ATTR_KILL_SUID | ATTR_MODE;
attr->ia_mode &= ~S_ISUID;
}
if ((inode->i_mode & (S_ISGID | S_IXGRP)) == (S_ISGID | S_IXGRP)) {
- attr->ia_valid |= ATTR_MODE;
+ attr->ia_valid |= ATTR_KILL_SGID | ATTR_MODE;
attr->ia_mode &= ~S_ISGID;
}
}
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] fuse: pass ATTR_KILL_SUID/ATTR_KILL_SGID mode bits to user space
2023-09-21 2:24 [PATCH] fuse: pass ATTR_KILL_SUID/ATTR_KILL_SGID mode bits to user space xiubli
@ 2023-10-07 7:50 ` Xiubo Li
0 siblings, 0 replies; 2+ messages in thread
From: Xiubo Li @ 2023-10-07 7:50 UTC (permalink / raw)
To: miklos; +Cc: linux-fsdevel, linux-kernel
Ping...
On 9/21/23 10:24, xiubli@redhat.com wrote:
> From: Xiubo Li <xiubli@redhat.com>
>
> Such as for the xfstest-dev's generic/684 test case it will clear
> suid and sgid if the fallocate request is commit by an unprivileged
> user.
>
> We need to pass the ATTR_KILL_SUID/ATTR_KILL_SGID flags to userspace.
>
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
> fs/fuse/dir.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
> index f67bef9d83c4..73dcf54efbff 100644
> --- a/fs/fuse/dir.c
> +++ b/fs/fuse/dir.c
> @@ -1938,11 +1938,11 @@ static int fuse_setattr(struct mnt_idmap *idmap, struct dentry *entry,
>
> attr->ia_mode = inode->i_mode;
> if (inode->i_mode & S_ISUID) {
> - attr->ia_valid |= ATTR_MODE;
> + attr->ia_valid |= ATTR_KILL_SUID | ATTR_MODE;
> attr->ia_mode &= ~S_ISUID;
> }
> if ((inode->i_mode & (S_ISGID | S_IXGRP)) == (S_ISGID | S_IXGRP)) {
> - attr->ia_valid |= ATTR_MODE;
> + attr->ia_valid |= ATTR_KILL_SGID | ATTR_MODE;
> attr->ia_mode &= ~S_ISGID;
> }
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-07 7:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-21 2:24 [PATCH] fuse: pass ATTR_KILL_SUID/ATTR_KILL_SGID mode bits to user space xiubli
2023-10-07 7:50 ` Xiubo Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).