From: David Howells <dhowells@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: David Howells <dhowells@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Christian Brauner <christian@brauner.io>,
David Laight <David.Laight@ACULAB.COM>,
Matthew Wilcox <willy@infradead.org>,
Jeff Layton <jlayton@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
linux-mm@kvack.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v6 09/13] iov_iter: Add a kernel-type iterator-only iteration function
Date: Fri, 22 Sep 2023 13:02:23 +0100 [thread overview]
Message-ID: <20230922120227.1173720-10-dhowells@redhat.com> (raw)
In-Reply-To: <20230922120227.1173720-1-dhowells@redhat.com>
Add an iteration function that can only iterate over kernel internal-type
iterators (ie. BVEC, KVEC, XARRAY) and not user-backed iterators (ie. UBUF
and IOVEC). This allows for smaller iterators to be built when it is known
the caller won't have a user-backed iterator.
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Alexander Viro <viro@zeniv.linux.org.uk>
cc: Jens Axboe <axboe@kernel.dk>
cc: Christoph Hellwig <hch@lst.de>
cc: Christian Brauner <christian@brauner.io>
cc: Matthew Wilcox <willy@infradead.org>
cc: Linus Torvalds <torvalds@linux-foundation.org>
cc: David Laight <David.Laight@ACULAB.COM>
cc: linux-block@vger.kernel.org
cc: linux-fsdevel@vger.kernel.org
cc: linux-mm@kvack.org
---
Notes:
Changes
=======
ver #6)
- Document the priv2 arg of iterate_and_advance_kernel().
include/linux/iov_iter.h | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/include/linux/iov_iter.h b/include/linux/iov_iter.h
index 270454a6703d..d8733dc22b54 100644
--- a/include/linux/iov_iter.h
+++ b/include/linux/iov_iter.h
@@ -271,4 +271,36 @@ size_t iterate_and_advance(struct iov_iter *iter, size_t len, void *priv,
return iterate_and_advance2(iter, len, priv, NULL, ustep, step);
}
+/**
+ * iterate_and_advance_kernel - Iterate over a kernel iterator
+ * @iter: The iterator to iterate over.
+ * @len: The amount to iterate over.
+ * @priv: Data for the step functions.
+ * @priv2: More data for the step functions.
+ * @step: Processing function; given kernel addresses.
+ *
+ * Like iterate_and_advance2(), but rejected UBUF and IOVEC iterators and does
+ * not take a user-step function.
+ */
+static __always_inline
+size_t iterate_and_advance_kernel(struct iov_iter *iter, size_t len, void *priv,
+ void *priv2, iov_step_f step)
+{
+ if (unlikely(iter->count < len))
+ len = iter->count;
+ if (unlikely(!len))
+ return 0;
+
+ if (iov_iter_is_bvec(iter))
+ return iterate_bvec(iter, len, priv, priv2, step);
+ if (iov_iter_is_kvec(iter))
+ return iterate_kvec(iter, len, priv, priv2, step);
+ if (iov_iter_is_xarray(iter))
+ return iterate_xarray(iter, len, priv, priv2, step);
+ if (iov_iter_is_discard(iter))
+ return iterate_discard(iter, len, priv, priv2, step);
+ WARN_ON_ONCE(1);
+ return 0;
+}
+
#endif /* _LINUX_IOV_ITER_H */
next prev parent reply other threads:[~2023-09-22 12:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 12:02 [PATCH v6 00/13] iov_iter: Convert the iterator macros into inline funcs David Howells
2023-09-22 12:02 ` [PATCH v6 01/13] iov_iter: Remove last_offset from iov_iter as it was for ITER_PIPE David Howells
2023-09-22 12:02 ` [PATCH v6 02/13] iov_iter: Be consistent about the __user tag on copy_mc_to_user() David Howells
2023-09-22 12:02 ` [PATCH v6 03/13] sound: Fix snd_pcm_readv()/writev() to use iov access functions David Howells
2023-09-22 12:02 ` [PATCH v6 04/13] infiniband: Use user_backed_iter() to see if iterator is UBUF/IOVEC David Howells
2023-09-22 12:02 ` [PATCH v6 05/13] iov_iter: Renumber ITER_* constants David Howells
2023-09-22 12:02 ` [PATCH v6 06/13] iov_iter: Derive user-backedness from the iterator type David Howells
2023-09-22 12:02 ` [PATCH v6 07/13] iov_iter: Convert iterate*() to inline funcs David Howells
2023-09-22 12:02 ` [PATCH v6 08/13] iov_iter: Don't deal with iter->copy_mc in memcpy_from_iter_mc() David Howells
2023-09-22 16:34 ` Linus Torvalds
2023-09-22 12:02 ` David Howells [this message]
2023-09-22 18:51 ` [PATCH v6 09/13] iov_iter: Add a kernel-type iterator-only iteration function Linus Torvalds
2023-09-22 12:02 ` [PATCH v6 10/13] iov_iter, net: Move csum_and_copy_to/from_iter() to net/ David Howells
2023-09-22 12:02 ` [PATCH v6 11/13] iov_iter, net: Fold in csum_and_memcpy() David Howells
2023-09-22 12:02 ` [PATCH v6 12/13] iov_iter, net: Merge csum_and_copy_from_iter{,_full}() together David Howells
2023-09-22 12:02 ` [PATCH v6 13/13] iov_iter, net: Move hash_and_copy_to_iter() to net/ David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230922120227.1173720-10-dhowells@redhat.com \
--to=dhowells@redhat.com \
--cc=David.Laight@ACULAB.COM \
--cc=axboe@kernel.dk \
--cc=christian@brauner.io \
--cc=hch@lst.de \
--cc=jlayton@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).