* [linux-next:master] BUILD REGRESSION df964ce9ef9fea10cf131bf6bad8658fde7956f6 @ 2023-09-30 5:25 kernel test robot 2023-09-30 21:56 ` Kees Cook 0 siblings, 1 reply; 5+ messages in thread From: kernel test robot @ 2023-09-30 5:25 UTC (permalink / raw) To: Andrew Morton Cc: Linux Memory Management List, alsa-devel, amd-gfx, bpf, intel-wired-lan, linux-arm-kernel, linux-arm-msm, linux-fsdevel, linux-hardening, patches tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: df964ce9ef9fea10cf131bf6bad8658fde7956f6 Add linux-next specific files for 20230929 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202309122047.cRi9yJrq-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202309130213.mSR7X2jZ-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202309192154.NJNpFIy5-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202309192314.VBsjiIm5-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202309212121.cul1pTRa-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202309212339.hxhBu2F1-lkp@intel.com https://lore.kernel.org/oe-kbuild-all/202309290750.bYBcf6Q2-lkp@intel.com Error/Warning: (recently discovered and may have been fixed) aarch64-linux-ld: ice_dpll.c:(.text+0x1124): undefined reference to `ice_cgu_get_pin_type' aarch64-linux-ld: ice_dpll.c:(.text+0x122c): undefined reference to `ice_cgu_get_pin_freq_supp' aarch64-linux-ld: ice_dpll.c:(.text+0xaa0): undefined reference to `ice_cgu_get_pin_name' aarch64-linux-ld: ice_dpll.c:(.text+0xab4): undefined reference to `ice_cgu_get_pin_type' aarch64-linux-ld: ice_lib.c:(.text+0x6064): undefined reference to `ice_is_cgu_present' aarch64-linux-ld: ice_lib.c:(.text+0x6070): undefined reference to `ice_is_clock_mux_present_e810t' arc-elf-ld: xfrm_algo.c:(.text+0x46c): undefined reference to `crypto_has_aead' arm-linux-gnueabi-ld: drivers/net/ethernet/intel/ice/ice_dpll.c:1647:(.text+0x34a4): undefined reference to `ice_cgu_get_pin_type' arm-linux-gnueabi-ld: drivers/net/ethernet/intel/ice/ice_dpll.c:1666:(.text+0x3704): undefined reference to `ice_cgu_get_pin_freq_supp' arm-linux-gnueabi-ld: drivers/net/ethernet/intel/ice/ice_lib.c:3998:(.text+0x166b0): undefined reference to `ice_is_cgu_present' arm-linux-gnueabi-ld: drivers/net/ethernet/intel/ice/ice_lib.c:4000:(.text+0x16734): undefined reference to `ice_is_clock_mux_present_e810t' drivers/cpufreq/sti-cpufreq.c:215:50: warning: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 2 [-Wformat-truncation=] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3928: warning: Function parameter or member 'srf_updates' not described in 'could_mpcc_tree_change_for_active_pipes' drivers/net/ethernet/intel/idpf/idpf_singleq_txrx.c:194:29: warning: variable 'tx_buf' set but not used [-Wunused-but-set-variable] fs/bcachefs/bcachefs_format.h:215:25: warning: 'p' offset 3 in 'struct bkey' isn't aligned to 4 [-Wpacked-not-aligned] fs/bcachefs/bcachefs_format.h:217:25: warning: 'version' offset 27 in 'struct bkey' isn't aligned to 4 [-Wpacked-not-aligned] ice_dpll.c:(.text+0x1104): undefined reference to `ice_cgu_get_pin_name' ice_dpll.c:(.text+0x15b4): undefined reference to `ice_get_cgu_state' ice_dpll.c:(.text+0x1ea0): undefined reference to `ice_get_cgu_rclk_pin_info' ice_dpll.c:(.text+0x2754): undefined reference to `ice_get_cgu_rclk_pin_info' ice_dpll.c:(.text+0xa64): undefined reference to `ice_cgu_get_pin_freq_supp' ice_dpll.c:(.text+0xe84): undefined reference to `ice_get_cgu_state' ice_lib.c:(.text+0x604c): undefined reference to `ice_is_phy_rclk_present' include/linux/fortify-string.h:57:33: warning: writing 8 bytes into a region of size 0 [-Wstringop-overflow=] kernel/bpf/helpers.c:1906:19: warning: no previous declaration for 'bpf_percpu_obj_new_impl' [-Wmissing-declarations] kernel/bpf/helpers.c:1942:18: warning: no previous declaration for 'bpf_percpu_obj_drop_impl' [-Wmissing-declarations] kernel/bpf/helpers.c:2477:18: warning: no previous declaration for 'bpf_throw' [-Wmissing-declarations] ld.lld: error: undefined symbol: crypto_has_aead ld: drivers/net/ethernet/intel/ice/ice_dpll.c:1647: undefined reference to `ice_cgu_get_pin_type' riscv64-linux-ld: drivers/net/ethernet/intel/ice/ice_dpll.c:1062:(.text+0x1236): undefined reference to `ice_get_cgu_state' riscv64-linux-ld: drivers/net/ethernet/intel/ice/ice_dpll.c:1667:(.text+0xdea): undefined reference to `ice_cgu_get_pin_name' riscv64-linux-ld: drivers/net/ethernet/intel/ice/ice_dpll.c:1777:(.text+0x24aa): undefined reference to `ice_get_cgu_rclk_pin_info' sound/pci/hda/cirrus_scodec_test.c:151:60: error: initializer element is not a compile-time constant sound/soc/mediatek/mt2701/mt2701-afe-clock-ctrl.c:44:50: warning: '%d' directive output may be truncated writing between 1 and 11 bytes into a region of size 10 [-Wformat-truncation=] xfrm_algo.c:(.text+0x46c): undefined reference to `crypto_has_aead' Unverified Error/Warning (likely false positive, please contact us if interested): Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml: mm/shrinker.c:100:1-7: preceding lock on line 83 sound/pci/hda/cs35l41_hda.c:1559 cs35l41_hda_probe() warn: passing zero to 'dev_err_probe' {standard input}:1247: Error: unknown pseudo-op: `.sho' {standard input}:1468: Error: unknown .loc sub-directive `is_' Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- alpha-allyesconfig | `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes |-- arc-allmodconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes | |-- fs-bcachefs-bcachefs_format.h:warning:p-offset-in-struct-bkey-isn-t-aligned-to | `-- fs-bcachefs-bcachefs_format.h:warning:version-offset-in-struct-bkey-isn-t-aligned-to |-- arc-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes | |-- fs-bcachefs-bcachefs_format.h:warning:p-offset-in-struct-bkey-isn-t-aligned-to | `-- fs-bcachefs-bcachefs_format.h:warning:version-offset-in-struct-bkey-isn-t-aligned-to |-- arc-defconfig | |-- arc-elf-ld:xfrm_algo.c:(.text):undefined-reference-to-crypto_has_aead | `-- xfrm_algo.c:(.text):undefined-reference-to-crypto_has_aead |-- arm-allmodconfig | |-- drivers-cpufreq-sti-cpufreq.c:warning:d-directive-output-may-be-truncated-writing-between-and-bytes-into-a-region-of-size | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes | `-- sound-soc-mediatek-mt2701-mt2701-afe-clock-ctrl.c:warning:d-directive-output-may-be-truncated-writing-between-and-bytes-into-a-region-of-size |-- arm-allyesconfig | |-- drivers-cpufreq-sti-cpufreq.c:warning:d-directive-output-may-be-truncated-writing-between-and-bytes-into-a-region-of-size | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes | `-- sound-soc-mediatek-mt2701-mt2701-afe-clock-ctrl.c:warning:d-directive-output-may-be-truncated-writing-between-and-bytes-into-a-region-of-size |-- arm-randconfig-r012-20220815 | |-- arm-linux-gnueabi-ld:drivers-net-ethernet-intel-ice-ice_dpll.c:(.text):undefined-reference-to-ice_cgu_get_pin_freq_supp | |-- arm-linux-gnueabi-ld:drivers-net-ethernet-intel-ice-ice_dpll.c:(.text):undefined-reference-to-ice_cgu_get_pin_type | |-- arm-linux-gnueabi-ld:drivers-net-ethernet-intel-ice-ice_lib.c:(.text):undefined-reference-to-ice_is_cgu_present | `-- arm-linux-gnueabi-ld:drivers-net-ethernet-intel-ice-ice_lib.c:(.text):undefined-reference-to-ice_is_clock_mux_present_e810t |-- arm64-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes | |-- include-linux-fortify-string.h:warning:writing-bytes-into-a-region-of-size | `-- sound-soc-mediatek-mt2701-mt2701-afe-clock-ctrl.c:warning:d-directive-output-may-be-truncated-writing-between-and-bytes-into-a-region-of-size |-- arm64-randconfig-001-20230929 | |-- aarch64-linux-ld:ice_dpll.c:(.text):undefined-reference-to-ice_cgu_get_pin_name | |-- aarch64-linux-ld:ice_dpll.c:(.text):undefined-reference-to-ice_cgu_get_pin_type | |-- aarch64-linux-ld:ice_lib.c:(.text):undefined-reference-to-ice_is_cgu_present | |-- aarch64-linux-ld:ice_lib.c:(.text):undefined-reference-to-ice_is_clock_mux_present_e810t | |-- ice_dpll.c:(.text):undefined-reference-to-ice_cgu_get_pin_freq_supp | |-- ice_dpll.c:(.text):undefined-reference-to-ice_get_cgu_rclk_pin_info | |-- ice_dpll.c:(.text):undefined-reference-to-ice_get_cgu_state | `-- ice_lib.c:(.text):undefined-reference-to-ice_is_phy_rclk_present |-- arm64-randconfig-002-20230927 | |-- aarch64-linux-ld:ice_dpll.c:(.text):undefined-reference-to-ice_cgu_get_pin_freq_supp | |-- aarch64-linux-ld:ice_dpll.c:(.text):undefined-reference-to-ice_cgu_get_pin_type | |-- ice_dpll.c:(.text):undefined-reference-to-ice_cgu_get_pin_name | |-- ice_dpll.c:(.text):undefined-reference-to-ice_get_cgu_rclk_pin_info | `-- ice_dpll.c:(.text):undefined-reference-to-ice_get_cgu_state |-- csky-allmodconfig | `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes |-- csky-allyesconfig | `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes |-- i386-allmodconfig | `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes |-- i386-allyesconfig | `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes |-- i386-buildonly-randconfig-005-20230929 | |-- kernel-bpf-helpers.c:warning:no-previous-declaration-for-bpf_percpu_obj_drop_impl | |-- kernel-bpf-helpers.c:warning:no-previous-declaration-for-bpf_percpu_obj_new_impl | `-- kernel-bpf-helpers.c:warning:no-previous-declaration-for-bpf_throw |-- i386-randconfig-006-20230929 | |-- kernel-bpf-helpers.c:warning:no-previous-declaration-for-bpf_percpu_obj_drop_impl | |-- kernel-bpf-helpers.c:warning:no-previous-declaration-for-bpf_percpu_obj_new_impl | `-- kernel-bpf-helpers.c:warning:no-previous-declaration-for-bpf_throw |-- i386-randconfig-a014-20211211 | `-- ld:drivers-net-ethernet-intel-ice-ice_dpll.c:undefined-reference-to-ice_cgu_get_pin_type |-- loongarch-allmodconfig | `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes |-- loongarch-allyesconfig | `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes |-- loongarch-defconfig | `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes |-- loongarch-randconfig-001-20230929 | |-- Documentation-devicetree-bindings-mfd-qcom-pm8xxx.yaml: | `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes |-- loongarch-randconfig-002-20230929 | `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes |-- m68k-allmodconfig | |-- fs-bcachefs-bcachefs_format.h:warning:p-offset-in-struct-bkey-isn-t-aligned-to | `-- fs-bcachefs-bcachefs_format.h:warning:version-offset-in-struct-bkey-isn-t-aligned-to |-- m68k-allyesconfig | |-- fs-bcachefs-bcachefs_format.h:warning:p-offset-in-struct-bkey-isn-t-aligned-to | `-- fs-bcachefs-bcachefs_format.h:warning:version-offset-in-struct-bkey-isn-t-aligned-to |-- microblaze-allmodconfig | `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes |-- microblaze-allyesconfig | `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes |-- mips-allmodconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes | |-- fs-bcachefs-bcachefs_format.h:warning:p-offset-in-struct-bkey-isn-t-aligned-to | `-- fs-bcachefs-bcachefs_format.h:warning:version-offset-in-struct-bkey-isn-t-aligned-to |-- mips-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes | |-- fs-bcachefs-bcachefs_format.h:warning:p-offset-in-struct-bkey-isn-t-aligned-to | `-- fs-bcachefs-bcachefs_format.h:warning:version-offset-in-struct-bkey-isn-t-aligned-to |-- openrisc-allmodconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes | |-- fs-bcachefs-bcachefs_format.h:warning:p-offset-in-struct-bkey-isn-t-aligned-to | `-- fs-bcachefs-bcachefs_format.h:warning:version-offset-in-struct-bkey-isn-t-aligned-to |-- openrisc-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes | |-- fs-bcachefs-bcachefs_format.h:warning:p-offset-in-struct-bkey-isn-t-aligned-to | `-- fs-bcachefs-bcachefs_format.h:warning:version-offset-in-struct-bkey-isn-t-aligned-to |-- parisc-allmodconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes | |-- fs-bcachefs-bcachefs_format.h:warning:p-offset-in-struct-bkey-isn-t-aligned-to | `-- fs-bcachefs-bcachefs_format.h:warning:version-offset-in-struct-bkey-isn-t-aligned-to |-- parisc-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes | |-- fs-bcachefs-bcachefs_format.h:warning:p-offset-in-struct-bkey-isn-t-aligned-to | `-- fs-bcachefs-bcachefs_format.h:warning:version-offset-in-struct-bkey-isn-t-aligned-to |-- powerpc-allmodconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes | |-- fs-bcachefs-bcachefs_format.h:warning:p-offset-in-struct-bkey-isn-t-aligned-to | |-- fs-bcachefs-bcachefs_format.h:warning:version-offset-in-struct-bkey-isn-t-aligned-to | `-- include-linux-fortify-string.h:warning:writing-bytes-into-a-region-of-size |-- powerpc-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes | |-- fs-bcachefs-bcachefs_format.h:warning:p-offset-in-struct-bkey-isn-t-aligned-to | |-- fs-bcachefs-bcachefs_format.h:warning:version-offset-in-struct-bkey-isn-t-aligned-to | `-- include-linux-fortify-string.h:warning:writing-bytes-into-a-region-of-size |-- powerpc-randconfig-001-20230929 | |-- drivers-net-ethernet-intel-idpf-idpf_singleq_txrx.c:warning:variable-tx_buf-set-but-not-used | |-- fs-bcachefs-bcachefs_format.h:warning:p-offset-in-struct-bkey-isn-t-aligned-to | `-- fs-bcachefs-bcachefs_format.h:warning:version-offset-in-struct-bkey-isn-t-aligned-to |-- powerpc-randconfig-003-20230929 | `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes |-- riscv-allmodconfig | `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes |-- riscv-allyesconfig | `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes |-- riscv-buildonly-randconfig-r001-20221205 | |-- riscv64-linux-ld:drivers-net-ethernet-intel-ice-ice_dpll.c:(.text):undefined-reference-to-ice_cgu_get_pin_name | |-- riscv64-linux-ld:drivers-net-ethernet-intel-ice-ice_dpll.c:(.text):undefined-reference-to-ice_get_cgu_rclk_pin_info | `-- riscv64-linux-ld:drivers-net-ethernet-intel-ice-ice_dpll.c:(.text):undefined-reference-to-ice_get_cgu_state |-- s390-allmodconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes | |-- fs-bcachefs-bcachefs_format.h:warning:p-offset-in-struct-bkey-isn-t-aligned-to | |-- fs-bcachefs-bcachefs_format.h:warning:version-offset-in-struct-bkey-isn-t-aligned-to | `-- include-linux-fortify-string.h:warning:writing-bytes-into-a-region-of-size |-- s390-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes | |-- fs-bcachefs-bcachefs_format.h:warning:p-offset-in-struct-bkey-isn-t-aligned-to | |-- fs-bcachefs-bcachefs_format.h:warning:version-offset-in-struct-bkey-isn-t-aligned-to | `-- include-linux-fortify-string.h:warning:writing-bytes-into-a-region-of-size |-- sh-randconfig-r011-20230418 | `-- standard-input:Error:unknown-pseudo-op:sho |-- sh-randconfig-r032-20230410 | `-- standard-input:Error:unknown-.loc-sub-directive-is_ |-- sparc-allmodconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes | |-- fs-bcachefs-bcachefs_format.h:warning:p-offset-in-struct-bkey-isn-t-aligned-to | `-- fs-bcachefs-bcachefs_format.h:warning:version-offset-in-struct-bkey-isn-t-aligned-to |-- sparc-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes | |-- fs-bcachefs-bcachefs_format.h:warning:p-offset-in-struct-bkey-isn-t-aligned-to | `-- fs-bcachefs-bcachefs_format.h:warning:version-offset-in-struct-bkey-isn-t-aligned-to |-- sparc-randconfig-001-20230929 | `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes |-- sparc64-allmodconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes | |-- fs-bcachefs-bcachefs_format.h:warning:p-offset-in-struct-bkey-isn-t-aligned-to | `-- fs-bcachefs-bcachefs_format.h:warning:version-offset-in-struct-bkey-isn-t-aligned-to |-- sparc64-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes | |-- fs-bcachefs-bcachefs_format.h:warning:p-offset-in-struct-bkey-isn-t-aligned-to | `-- fs-bcachefs-bcachefs_format.h:warning:version-offset-in-struct-bkey-isn-t-aligned-to |-- sparc64-randconfig-002-20230929 | `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes |-- x86_64-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes | `-- include-linux-fortify-string.h:warning:writing-bytes-into-a-region-of-size |-- x86_64-buildonly-randconfig-005-20230929 | `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes |-- x86_64-randconfig-015-20230929 | `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes |-- x86_64-randconfig-071-20230929 | `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes |-- x86_64-randconfig-076-20230929 | `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes |-- x86_64-randconfig-103-20230927 | `-- mm-shrinker.c:preceding-lock-on-line |-- x86_64-randconfig-161-20230929 | `-- sound-pci-hda-cs35l41_hda.c-cs35l41_hda_probe()-warn:passing-zero-to-dev_err_probe `-- xtensa-randconfig-002-20230929 `-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc.c:warning:Function-parameter-or-member-srf_updates-not-described-in-could_mpcc_tree_change_for_active_pipes clang_recent_errors |-- arm-ep93xx_defconfig | `-- ld.lld:error:undefined-symbol:crypto_has_aead `-- hexagon-allmodconfig `-- sound-pci-hda-cirrus_scodec_test.c:error:initializer-element-is-not-a-compile-time-constant elapsed time: 1457m configs tested: 134 configs skipped: 2 tested configs: alpha allnoconfig gcc alpha allyesconfig gcc alpha defconfig gcc arc allmodconfig gcc arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20230929 gcc arm allmodconfig gcc arm allnoconfig gcc arm allyesconfig gcc arm defconfig gcc arm randconfig-001-20230929 gcc arm64 allnoconfig gcc arm64 allyesconfig gcc arm64 defconfig gcc csky allmodconfig gcc csky allnoconfig gcc csky allyesconfig gcc csky defconfig gcc i386 allmodconfig gcc i386 allnoconfig gcc i386 allyesconfig gcc i386 buildonly-randconfig-001-20230929 gcc i386 buildonly-randconfig-002-20230929 gcc i386 buildonly-randconfig-003-20230929 gcc i386 buildonly-randconfig-004-20230929 gcc i386 buildonly-randconfig-005-20230929 gcc i386 buildonly-randconfig-006-20230929 gcc i386 debian-10.3 gcc i386 defconfig gcc i386 randconfig-001-20230929 gcc i386 randconfig-002-20230929 gcc i386 randconfig-003-20230929 gcc i386 randconfig-004-20230929 gcc i386 randconfig-005-20230929 gcc i386 randconfig-006-20230929 gcc i386 randconfig-011-20230929 gcc i386 randconfig-012-20230929 gcc i386 randconfig-013-20230929 gcc i386 randconfig-014-20230929 gcc i386 randconfig-015-20230929 gcc i386 randconfig-016-20230929 gcc loongarch allmodconfig gcc loongarch allnoconfig gcc loongarch allyesconfig gcc loongarch defconfig gcc loongarch randconfig-001-20230929 gcc m68k allmodconfig gcc m68k allnoconfig gcc m68k allyesconfig gcc m68k defconfig gcc microblaze allmodconfig gcc microblaze allnoconfig gcc microblaze allyesconfig gcc microblaze defconfig gcc mips allmodconfig gcc mips allnoconfig gcc mips allyesconfig gcc nios2 allmodconfig gcc nios2 allnoconfig gcc nios2 allyesconfig gcc nios2 defconfig gcc openrisc allmodconfig gcc openrisc allnoconfig gcc openrisc allyesconfig gcc openrisc defconfig gcc parisc allmodconfig gcc parisc allnoconfig gcc parisc allyesconfig gcc parisc defconfig gcc parisc64 defconfig gcc powerpc allmodconfig gcc powerpc allnoconfig gcc powerpc allyesconfig gcc riscv allmodconfig gcc riscv allnoconfig gcc riscv allyesconfig gcc riscv defconfig gcc riscv randconfig-001-20230929 gcc riscv rv32_defconfig gcc s390 allmodconfig gcc s390 allnoconfig gcc s390 allyesconfig gcc s390 defconfig gcc s390 randconfig-001-20230929 gcc sh allmodconfig gcc sh allnoconfig gcc sh allyesconfig gcc sh defconfig gcc sparc allmodconfig gcc sparc allnoconfig gcc sparc allyesconfig gcc sparc defconfig gcc sparc randconfig-001-20230929 gcc sparc64 allmodconfig gcc sparc64 allyesconfig gcc sparc64 defconfig gcc um allmodconfig clang um allnoconfig clang um allyesconfig clang um defconfig gcc um i386_defconfig gcc um x86_64_defconfig gcc x86_64 allnoconfig gcc x86_64 allyesconfig gcc x86_64 buildonly-randconfig-001-20230929 gcc x86_64 buildonly-randconfig-002-20230929 gcc x86_64 buildonly-randconfig-003-20230929 gcc x86_64 buildonly-randconfig-004-20230929 gcc x86_64 buildonly-randconfig-005-20230929 gcc x86_64 buildonly-randconfig-006-20230929 gcc x86_64 defconfig gcc x86_64 randconfig-001-20230929 gcc x86_64 randconfig-002-20230929 gcc x86_64 randconfig-003-20230929 gcc x86_64 randconfig-004-20230929 gcc x86_64 randconfig-005-20230929 gcc x86_64 randconfig-006-20230929 gcc x86_64 randconfig-011-20230929 gcc x86_64 randconfig-012-20230929 gcc x86_64 randconfig-013-20230929 gcc x86_64 randconfig-014-20230929 gcc x86_64 randconfig-015-20230929 gcc x86_64 randconfig-016-20230929 gcc x86_64 randconfig-071-20230929 gcc x86_64 randconfig-072-20230929 gcc x86_64 randconfig-073-20230929 gcc x86_64 randconfig-074-20230929 gcc x86_64 randconfig-075-20230929 gcc x86_64 randconfig-076-20230929 gcc x86_64 rhel-8.3-rust clang x86_64 rhel-8.3 gcc xtensa allnoconfig gcc -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [linux-next:master] BUILD REGRESSION df964ce9ef9fea10cf131bf6bad8658fde7956f6 2023-09-30 5:25 [linux-next:master] BUILD REGRESSION df964ce9ef9fea10cf131bf6bad8658fde7956f6 kernel test robot @ 2023-09-30 21:56 ` Kees Cook 2023-10-02 3:22 ` Kent Overstreet 0 siblings, 1 reply; 5+ messages in thread From: Kees Cook @ 2023-09-30 21:56 UTC (permalink / raw) To: Kent Overstreet Cc: Andrew Morton, Brian Foster, kernel test robot, Linux Memory Management List, linux-fsdevel, linux-bcachefs, linux-hardening Hi Kent, Andrew pointed this out to me, and it's a FORTIFY issue under a W=1 build: On Sat, Sep 30, 2023 at 01:25:34PM +0800, kernel test robot wrote: > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > branch HEAD: df964ce9ef9fea10cf131bf6bad8658fde7956f6 Add linux-next specific files for 20230929 > > Error/Warning reports: > > [...] > https://lore.kernel.org/oe-kbuild-all/202309192314.VBsjiIm5-lkp@intel.com fs/bcachefs/extents.c: In function 'bch2_bkey_append_ptr': include/linux/fortify-string.h:57:33: warning: writing 8 bytes into a region of size 0 [-Wstringop-overflow=] 57 | #define __underlying_memcpy __builtin_memcpy | ^ include/linux/fortify-string.h:648:9: note: in expansion of macro '__underlying_memcpy' 648 | __underlying_##op(p, q, __fortify_size); \ | ^~~~~~~~~~~~~ include/linux/fortify-string.h:693:26: note: in expansion of macro '__fortify_memcpy_chk' 693 | #define memcpy(p, q, s) __fortify_memcpy_chk(p, q, s, \ | ^~~~~~~~~~~~~~~~~~~~ fs/bcachefs/extents.c:235:17: note: in expansion of macro 'memcpy' 235 | memcpy((void *) &k->v + bkey_val_bytes(&k->k), | ^~~~~~ fs/bcachefs/bcachefs_format.h:287:33: note: destination object 'v' of size 0 287 | struct bch_val v; | ^ The problem here is the struct bch_val is explicitly declared as a zero-sized array, so the compiler becomes unhappy. :) Converting bch_val to a flexible array will just kick the can down the road, since this is going to run into -Wflex-array-member-not-at-end soon too since bch_val overlaps with other structures: struct bch_inode_v3 { struct bch_val v; __le64 bi_journal_seq; ... }; As a container_of() target, this is fine -- leave it a zero-sized array. The problem is using it as a destination for memcpy, etc, since the compiler will believe it to be 0 sized. Instead, we need to impart a type of some kind so that the compiler can actually unambiguously reason about sizes. The memcpy() in the warning is targeting bch_val, so I think the best fix is to correctly handle the different types. So just to have everything in front of me, here's a summary of what I'm seeing in the code: struct bkey { /* Size of combined key and value, in u64s */ __u8 u64s; ... }; /* Empty placeholder struct, for container_of() */ struct bch_val { __u64 __nothing[0]; }; struct bkey_i { __u64 _data[0]; struct bkey k; struct bch_val v; }; static inline void bch2_bkey_append_ptr(struct bkey_i *k, struct bch_extent_ptr ptr) { EBUG_ON(bch2_bkey_has_device(bkey_i_to_s(k), ptr.dev)); switch (k->k.type) { case KEY_TYPE_btree_ptr: case KEY_TYPE_btree_ptr_v2: case KEY_TYPE_extent: EBUG_ON(bkey_val_u64s(&k->k) >= BKEY_EXTENT_VAL_U64s_MAX); ptr.type = 1 << BCH_EXTENT_ENTRY_ptr; memcpy((void *) &k->v + bkey_val_bytes(&k->k), &ptr, sizeof(ptr)); k->k.u64s++; break; default: BUG(); } } So this is appending u64s into the region that start with bkey_i. Could this gain a u64 flexible array? struct bkey_i { __u64 _data[0]; struct bkey k; struct bch_val v; __u64 ptrs[]; }; Then the memcpy() could be just a direct assignment: k->ptrs[bkey_val_u64s(&k->k)] = (u64)ptr; k->k.u64s++; Alternatively, perhaps struct bkey could be the one to grow this flexible array, and then it could eventually be tracked with __counted_by (but not today since it expects to count the array element count, not a whole struct size): struct bkey { /* Size of combined key and value, in u64s */ __u8 u64s; ... __u64 data[] __counted_by(.u64s - BKEY_U64s); }; And bch_val could be dropped... Then the memcpy becomes: k->k.u64s++; k->k.data[bkey_val_u64s(&k->k)] = (u64)ptr; It just seems like there is a lot of work happening that could really just type casting or unions... What do you think? -- Kees Cook ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [linux-next:master] BUILD REGRESSION df964ce9ef9fea10cf131bf6bad8658fde7956f6 2023-09-30 21:56 ` Kees Cook @ 2023-10-02 3:22 ` Kent Overstreet 2023-10-02 4:52 ` Kees Cook 0 siblings, 1 reply; 5+ messages in thread From: Kent Overstreet @ 2023-10-02 3:22 UTC (permalink / raw) To: Kees Cook Cc: Andrew Morton, Brian Foster, kernel test robot, Linux Memory Management List, linux-fsdevel, linux-bcachefs, linux-hardening On Sat, Sep 30, 2023 at 02:56:01PM -0700, Kees Cook wrote: > Hi Kent, > > Andrew pointed this out to me, and it's a FORTIFY issue under a W=1 build: > > On Sat, Sep 30, 2023 at 01:25:34PM +0800, kernel test robot wrote: > > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > branch HEAD: df964ce9ef9fea10cf131bf6bad8658fde7956f6 Add linux-next specific files for 20230929 > > > > Error/Warning reports: > > > > [...] > > https://lore.kernel.org/oe-kbuild-all/202309192314.VBsjiIm5-lkp@intel.com > > fs/bcachefs/extents.c: In function 'bch2_bkey_append_ptr': > include/linux/fortify-string.h:57:33: warning: writing 8 bytes into a region of size 0 [-Wstringop-overflow=] > 57 | #define __underlying_memcpy __builtin_memcpy > | ^ > include/linux/fortify-string.h:648:9: note: in expansion of macro '__underlying_memcpy' > 648 | __underlying_##op(p, q, __fortify_size); \ > | ^~~~~~~~~~~~~ > include/linux/fortify-string.h:693:26: note: in expansion of macro '__fortify_memcpy_chk' > 693 | #define memcpy(p, q, s) __fortify_memcpy_chk(p, q, s, \ > | ^~~~~~~~~~~~~~~~~~~~ > fs/bcachefs/extents.c:235:17: note: in expansion of macro 'memcpy' > 235 | memcpy((void *) &k->v + bkey_val_bytes(&k->k), > | ^~~~~~ > fs/bcachefs/bcachefs_format.h:287:33: note: destination object 'v' of size 0 > 287 | struct bch_val v; > | ^ > > The problem here is the struct bch_val is explicitly declared as a > zero-sized array, so the compiler becomes unhappy. :) Converting bch_val > to a flexible array will just kick the can down the road, since this is > going to run into -Wflex-array-member-not-at-end soon too since bch_val > overlaps with other structures: > > struct bch_inode_v3 { > struct bch_val v; > > __le64 bi_journal_seq; > ... > }; > > As a container_of() target, this is fine -- leave it a zero-sized > array. The problem is using it as a destination for memcpy, etc, since > the compiler will believe it to be 0 sized. Instead, we need to impart > a type of some kind so that the compiler can actually unambiguously > reason about sizes. The memcpy() in the warning is targeting bch_val, > so I think the best fix is to correctly handle the different types. > > So just to have everything in front of me, here's a summary of what I'm > seeing in the code: > > struct bkey { > /* Size of combined key and value, in u64s */ > __u8 u64s; > ... > }; > > /* Empty placeholder struct, for container_of() */ > struct bch_val { > __u64 __nothing[0]; > }; > > struct bkey_i { > __u64 _data[0]; > > struct bkey k; > struct bch_val v; > }; > > static inline void bch2_bkey_append_ptr(struct bkey_i *k, struct bch_extent_ptr ptr) > { > EBUG_ON(bch2_bkey_has_device(bkey_i_to_s(k), ptr.dev)); > > switch (k->k.type) { > case KEY_TYPE_btree_ptr: > case KEY_TYPE_btree_ptr_v2: > case KEY_TYPE_extent: > EBUG_ON(bkey_val_u64s(&k->k) >= BKEY_EXTENT_VAL_U64s_MAX); > > ptr.type = 1 << BCH_EXTENT_ENTRY_ptr; > > memcpy((void *) &k->v + bkey_val_bytes(&k->k), > &ptr, > sizeof(ptr)); > k->k.u64s++; > break; > default: > BUG(); > } > } > > So this is appending u64s into the region that start with bkey_i. Could > this gain a u64 flexible array? > > struct bkey_i { > __u64 _data[0]; > > struct bkey k; > struct bch_val v; > __u64 ptrs[]; > }; > > Then the memcpy() could be just a direct assignment: > > k->ptrs[bkey_val_u64s(&k->k)] = (u64)ptr; > k->k.u64s++; No, that's not going to work. You're adding a field that's specific to bch_extent (and not even correct for that) to bkey_i, the generic key; there are many other different types of values. > Alternatively, perhaps struct bkey could be the one to grow this flexible > array, and then it could eventually be tracked with __counted_by (but > not today since it expects to count the array element count, not a whole > struct size): > > struct bkey { > /* Size of combined key and value, in u64s */ > __u8 u64s; > ... > __u64 data[] __counted_by(.u64s - BKEY_U64s); > }; > > And bch_val could be dropped... bch_val can't be dropped. bkey_i is different from bkey; bkey_i is a bkey with an inline value, we also have bkey_s and bkey_s_c for a bkey with a split value (and const variation); bch_val is in bkey_i and not bkey because container_of to get to the value is correct for bkey_i, but not bkey. > Then the memcpy becomes: > > k->k.u64s++; > k->k.data[bkey_val_u64s(&k->k)] = (u64)ptr; > > It just seems like there is a lot of work happening that could really > just type casting or unions... Honestly, I think we really just need an escape hatch. Casting to a void pointer clearly isn't it - and this isn't the only issue I'm still seeing with all the recent FORTIFY_SOURCE stuff, and honestly it's been making me tear my hair out. I'm not leaping at the chance to reorganize my fundamental data structures for this. Can we get such an escape hatch? ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [linux-next:master] BUILD REGRESSION df964ce9ef9fea10cf131bf6bad8658fde7956f6 2023-10-02 3:22 ` Kent Overstreet @ 2023-10-02 4:52 ` Kees Cook 2023-10-03 13:27 ` Kent Overstreet 0 siblings, 1 reply; 5+ messages in thread From: Kees Cook @ 2023-10-02 4:52 UTC (permalink / raw) To: Kent Overstreet Cc: Andrew Morton, Brian Foster, kernel test robot, Linux Memory Management List, linux-fsdevel, linux-bcachefs, linux-hardening On Sun, Oct 01, 2023 at 11:22:39PM -0400, Kent Overstreet wrote: > I'm not leaping at the chance to reorganize my fundamental data > structures for this. Yeah, understood. Thanks for taking a look at it! > Can we get such an escape hatch? Sure, please use unsafe_memcpy(), and include a comment on how the sizing has been bounds checked, etc. -- Kees Cook ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [linux-next:master] BUILD REGRESSION df964ce9ef9fea10cf131bf6bad8658fde7956f6 2023-10-02 4:52 ` Kees Cook @ 2023-10-03 13:27 ` Kent Overstreet 0 siblings, 0 replies; 5+ messages in thread From: Kent Overstreet @ 2023-10-03 13:27 UTC (permalink / raw) To: Kees Cook Cc: Andrew Morton, Brian Foster, kernel test robot, Linux Memory Management List, linux-fsdevel, linux-bcachefs, linux-hardening On Sun, Oct 01, 2023 at 09:52:22PM -0700, Kees Cook wrote: > On Sun, Oct 01, 2023 at 11:22:39PM -0400, Kent Overstreet wrote: > > I'm not leaping at the chance to reorganize my fundamental data > > structures for this. > > Yeah, understood. Thanks for taking a look at it! > > > Can we get such an escape hatch? > > Sure, please use unsafe_memcpy(), and include a comment on how the sizing > has been bounds checked, etc. Thanks, I knew there had to be one :) ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-03 13:28 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-09-30 5:25 [linux-next:master] BUILD REGRESSION df964ce9ef9fea10cf131bf6bad8658fde7956f6 kernel test robot 2023-09-30 21:56 ` Kees Cook 2023-10-02 3:22 ` Kent Overstreet 2023-10-02 4:52 ` Kees Cook 2023-10-03 13:27 ` Kent Overstreet
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).