From: Christian Brauner <brauner@kernel.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Mateusz Guzik <mjguzik@gmail.com>, Jann Horn <jannh@google.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] vfs: shave work on failed file open
Date: Tue, 10 Oct 2023 10:29:27 +0200 [thread overview]
Message-ID: <20231010-statik-zoomen-49dd9e81aff6@brauner> (raw)
In-Reply-To: <20231010030615.GO800259@ZenIV>
> is buried in the previous paragraph and it's not obvious that it applies to
> the last one as well. Incidentally, I would probably turn that fragment
massaged to clarify
> (in io_uring/openclose.c:io_close()) into
> spin_lock(&files->file_lock);
> file = files_lookup_fd_locked(files, close->fd);
> if (!file || io_is_uring_fops(file)) {
> spin_unlock(&files->file_lock);
> goto err;
> }
done
next prev parent reply other threads:[~2023-10-10 8:29 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 16:22 [PATCH v2] vfs: shave work on failed file open Mateusz Guzik
2023-09-26 19:00 ` Linus Torvalds
2023-09-26 19:28 ` Mateusz Guzik
2023-09-27 14:09 ` Christian Brauner
2023-09-27 14:34 ` Mateusz Guzik
2023-09-27 17:48 ` Linus Torvalds
2023-09-27 17:56 ` Mateusz Guzik
2023-09-27 18:05 ` Linus Torvalds
2023-09-27 18:32 ` Mateusz Guzik
2023-09-27 20:27 ` Linus Torvalds
2023-09-27 21:06 ` Mateusz Guzik
2023-09-27 21:18 ` Linus Torvalds
2023-09-27 21:30 ` Mateusz Guzik
2023-09-28 13:25 ` Christian Brauner
2023-09-28 14:05 ` Christian Brauner
2023-09-28 14:43 ` Jann Horn
2023-09-28 17:21 ` Linus Torvalds
2023-09-29 9:20 ` Christian Brauner
2023-09-29 13:31 ` Jann Horn
2023-09-29 19:57 ` Christian Brauner
2023-09-29 21:23 ` Mateusz Guzik
2023-09-29 21:39 ` Mateusz Guzik
2023-09-29 23:57 ` Linus Torvalds
2023-09-30 9:04 ` Christian Brauner
2023-10-03 16:45 ` Nathan Chancellor
2023-10-10 3:06 ` Al Viro
2023-10-10 8:29 ` Christian Brauner [this message]
2023-09-29 22:24 ` Matthew Wilcox
2023-09-29 23:02 ` Jann Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231010-statik-zoomen-49dd9e81aff6@brauner \
--to=brauner@kernel.org \
--cc=jannh@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjguzik@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).