linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jesse Hathaway <jesse@mbuki-mvuki.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Christoph Hellwig <hch@lst.de>,
	Florian Weimer <fweimer@redhat.com>,
	Aleksa Sarai <cyphar@cyphar.com>,
	linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
	stable@vger.kernel.org
Subject: Re: [PATCH] attr: block mode changes of symlinks
Date: Wed, 18 Oct 2023 20:40:44 +0200	[thread overview]
Message-ID: <2023101819-satisfied-drool-49bb@gregkh> (raw)
In-Reply-To: <CANSNSoUYMdPPLuZhofOW6DaKzCF47WhZ+T9BnL8sA37M7b4F+g@mail.gmail.com>

On Wed, Oct 18, 2023 at 01:34:13PM -0500, Jesse Hathaway wrote:
> > If this holds up without regressions than all LTSes. That's what Amir
> > and Leah did for some other work. I can add that to the comment for
> > clarity.
> 
> Unfortunately, this has not held up in LTSes without causing
> regressions, specifically in crun:
> 
> Crun issue and patch
>  1. https://github.com/containers/crun/issues/1308
>  2. https://github.com/containers/crun/pull/1309

So thre's a fix already for this, they agree that symlinks shouldn't
have modes, so what's the issue?

> Debian bug report
>  1. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1053821

Same report.

> I think it should be reverted in LTSes and possibly in upstream.

It needs to reverted in Linus's tree first, otherwise you will hit the
same problem when moving to a new kernel.

> P.S. apologies for not having the correct threading headers. I am not on
> the list.

You can always grab the mail on lore.kernel.org and respond to it there,
you are trying to dig up a months old email and we don't really have any
context at all (I had to go to lore to figure it out...)

thanks,

greg k-h

  reply	other threads:[~2023-10-18 18:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18 18:34 [PATCH] attr: block mode changes of symlinks Jesse Hathaway
2023-10-18 18:40 ` Greg KH [this message]
2023-10-18 18:49   ` Jesse Hathaway
2023-10-18 19:09     ` Greg KH
2023-10-20  8:34     ` Linux regression tracking (Thorsten Leemhuis)
2023-10-20 11:01       ` Christian Brauner
2023-10-20 13:26         ` Giuseppe Scrivano
2023-10-20 14:25         ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2023-07-12  9:56 Christian Brauner
2023-07-12 16:21 ` Greg KH
2023-07-12 17:58   ` Christian Brauner
2023-07-12 16:24 ` Linus Torvalds
2023-07-12 17:56   ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023101819-satisfied-drool-49bb@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=cyphar@cyphar.com \
    --cc=fweimer@redhat.com \
    --cc=hch@lst.de \
    --cc=jesse@mbuki-mvuki.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).