From: "Darrick J. Wong" <djwong@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Christian Brauner <brauner@kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Shirley Ma <shirley.ma@oracle.com>
Cc: hch@lst.de, jstancek@redhat.com, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [GIT PULL] iomap: bug fixes for 6.6-rc7
Date: Mon, 23 Oct 2023 15:38:10 -0700 [thread overview]
Message-ID: <20231023223810.GW3195650@frogsfrogsfrogs> (raw)
In-Reply-To: <CAHk-=whNsCXwidLvx8u_JBH91=Z5EFw9FVj57HQ51P7uWs4yGQ@mail.gmail.com>
On Sat, Oct 21, 2023 at 09:46:35AM -0700, Linus Torvalds wrote:
> On Fri, 20 Oct 2023 at 23:27, Darrick J. Wong <djwong@kernel.org> wrote:
> >
> > Please pull this branch with changes for iomap for 6.6-rc7.
> >
> > As usual, I did a test-merge with the main upstream branch as of a few
> > minutes ago, and didn't see any conflicts. Please let me know if you
> > encounter any problems.
>
> .. and as usual, the branch you point to does not actually exist.
>
> Because you *again* pointed to the wrong tree.
>
> This time I remembered what the mistake was last time, and picked out
> the right tree by hand, but *please* just fix your completely broken
> scripts or workflow.
>
> > https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git iomap-6.6-fixes-5
>
> No.
>
> It's pub/scm/fs/xfs/xfs-linux, once again.
Sorry about that. After reviewing the output of git request-pull, I
have learned that if you provide a $url argument that does not point to
a repo containing $start, it will print a warning to stderr and emit a
garbage pull request to stdout anyway. No --force required or anything.
Piping stdout to mutt without checking the return code is therefore a
bad idea.
I have now updated my wrapper script to buffer the entire pull request
contents and check the return value before proceeding.
It is a poor workman who blames his tools, so I declare publicly that
you have an idiot for a maintainer.
Christian: Do you have the bandwidth to take over fs/iomap/?
--D
>
> Linus
next prev parent reply other threads:[~2023-10-23 22:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-21 6:27 [GIT PULL] iomap: bug fixes for 6.6-rc7 Darrick J. Wong
2023-10-21 16:46 ` Linus Torvalds
2023-10-23 22:38 ` Darrick J. Wong [this message]
2023-10-24 11:47 ` Christian Brauner
2023-10-26 3:13 ` Darrick J. Wong
2023-10-26 11:54 ` Christian Brauner
2023-10-27 0:43 ` Darrick J. Wong
2023-10-26 18:10 ` Linus Torvalds
2023-10-26 20:20 ` Jeff Layton
2023-10-27 18:46 ` Christian Brauner
2023-10-27 23:30 ` Linus Torvalds
2023-10-28 16:56 ` Christian Brauner
2023-10-21 17:57 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231023223810.GW3195650@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=brauner@kernel.org \
--cc=hch@lst.de \
--cc=jstancek@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=shirley.ma@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).