linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: LOOP_CONFIGURE uevents
Date: Tue, 24 Oct 2023 10:42:46 +0200	[thread overview]
Message-ID: <20231024-wurzel-rankt-d9cebb866412@brauner> (raw)
In-Reply-To: <ZTds8va6evIjnpJG@infradead.org>

On Tue, Oct 24, 2023 at 12:06:26AM -0700, Christoph Hellwig wrote:
> On Mon, Oct 23, 2023 at 04:08:21PM +0200, Christian Brauner wrote:
> > No you get uevents if you trigger a partition rescan but only if there
> > are actually partitions. What you never get however is a media change
> > event even though we do increment the disk sequence number and attach an
> > image to the loop device.
> > 
> > This seems problematic because we leave userspace unable to listen for
> > attaching images to a loop device. Shouldn't we regenerate the media
> > change event after we're done setting up the device and before the
> > partition rescan for LOOP_CONFIGURE?
> 
> Maybe.  I think people mostly didn't care about the even anyway, but
> about the changing sequence number to check that the content hasn't
> changed.

Yes, exactly. The core is the changed sequence number but you don't get
that notification if you don't have any partitions and you request a
partition rescan from LOOP_CONFIGURE.

So I think we should always send the media change event for the sequence
number independent of the partition notification.

      reply	other threads:[~2023-10-24  8:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18 15:29 [PATCH] fs: Avoid grabbing sb->s_umount under bdev->bd_holder_lock Jan Kara
2023-10-18 15:46 ` Christoph Hellwig
2023-10-19  8:16 ` Christian Brauner
2023-10-19  8:33 ` Christian Brauner
2023-10-19 10:57   ` Jan Kara
2023-10-20 11:18     ` Christian Brauner
2023-10-19 13:40   ` Christoph Hellwig
2023-10-20 11:31     ` Christian Brauner
2023-10-20 12:04       ` Jan Kara
2023-10-23  7:40         ` Christian Brauner
2023-10-23 15:35           ` loop change deprecation bdev->bd_holder_lock Christian Brauner
2023-10-24  7:03             ` Christoph Hellwig
2023-10-24  8:44               ` loop change deprecation Christian Brauner
2023-10-23 14:08         ` LOOP_CONFIGURE uevents Christian Brauner
2023-10-24  7:06           ` Christoph Hellwig
2023-10-24  8:42             ` Christian Brauner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231024-wurzel-rankt-d9cebb866412@brauner \
    --to=brauner@kernel.org \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).