From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2EE330CFC for ; Tue, 24 Oct 2023 15:16:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="erysdHYc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3097AC43140; Tue, 24 Oct 2023 15:16:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698160598; bh=384E0IpiWf1c5LBlqx+nUImYpUlAfTxy1Pr+7exx5SA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=erysdHYcPRF40mcPCQwGtWi77Nepupkr5NleWyiCZintf3tRGrPKlCk+uDPq3Sng9 23Xgp1QCAo7oJrvsldW/oZrKzbcwIiAL+I0gvPiFRUCO+MXqoVfReiIJ0WqfN8ZuaF rPnixqPbiIMQ47dHd6d8UdHc8ski22IxiXJTdorEVj683y08+gH4K8/ohj72EP5TZF Afv4BZqTrgiQ/hVq6YntUdWVGbGbvVM1DJqTHlfJW+28IVitn+MvBzBXMJCCzz/jOB wLo/w+aI0ttwawjttb/Bm83M+ZklQIdb7LPnghroApXjpozUL/Zyllaa/Z+gwVOlAc NZ3U70CfpVK0Q== Date: Tue, 24 Oct 2023 08:16:37 -0700 From: "Darrick J. Wong" To: Christian Brauner Cc: Jan Kara , Christoph Hellwig , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 10/10] blkdev: comment fs_holder_ops Message-ID: <20231024151637.GF11424@frogsfrogsfrogs> References: <20231024-vfs-super-freeze-v2-0-599c19f4faac@kernel.org> <20231024-vfs-super-freeze-v2-10-599c19f4faac@kernel.org> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231024-vfs-super-freeze-v2-10-599c19f4faac@kernel.org> On Tue, Oct 24, 2023 at 03:01:16PM +0200, Christian Brauner wrote: > Add a comment to @fs_holder_ops that @holder must point to a superblock. > > Signed-off-by: Christian Brauner Looks good! Reviewed-by: Darrick J. Wong --D > --- > include/linux/blkdev.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 1bc776335ff8..abf71cce785c 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -1480,6 +1480,11 @@ struct blk_holder_ops { > int (*thaw)(struct block_device *bdev); > }; > > +/* > + * For filesystems using @fs_holder_ops, the @holder argument passed to > + * helpers used to open and claim block devices via > + * bd_prepare_to_claim() must point to a superblock. > + */ > extern const struct blk_holder_ops fs_holder_ops; > > /* > > -- > 2.34.1 >