linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] fs: Remove unneeded semicolon
Date: Thu, 26 Oct 2023 17:03:35 +0200	[thread overview]
Message-ID: <20231026150334.GA13945@redhat.com> (raw)
In-Reply-To: <20231026005634.6581-1-yang.lee@linux.alibaba.com>

On 10/26, Yang Li wrote:
>
> @@ -3826,7 +3826,7 @@ static struct task_struct *first_tid(struct pid *pid, int tid, loff_t f_pos,
>  	for_each_thread(task, pos) {
>  		if (!nr--)
>  			goto found;
> -	};
> +	}

Ah, I forgot to remove this semicolon :/

This is on top of

	document-while_each_thread-change-first_tid-to-use-for_each_thread.patch

perhaps this cleanup can be folded into the patch above along with Yang's sob ?

If Yang doesn't object.

Oleg.


  reply	other threads:[~2023-10-26 15:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-26  0:56 [PATCH -next] fs: Remove unneeded semicolon Yang Li
2023-10-26 15:03 ` Oleg Nesterov [this message]
2023-10-26 15:23   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231026150334.GA13945@redhat.com \
    --to=oleg@redhat.com \
    --cc=abaci@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yang.lee@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).