* [PATCH -next] fs: Remove unneeded semicolon
@ 2023-10-26 0:56 Yang Li
2023-10-26 15:03 ` Oleg Nesterov
0 siblings, 1 reply; 3+ messages in thread
From: Yang Li @ 2023-10-26 0:56 UTC (permalink / raw)
To: akpm, oleg; +Cc: linux-kernel, linux-fsdevel, Yang Li, Abaci Robot
./fs/proc/base.c:3829:2-3: Unneeded semicolon
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7057
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
fs/proc/base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/proc/base.c b/fs/proc/base.c
index bfe9547d16f9..dd31e3b6bf77 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -3826,7 +3826,7 @@ static struct task_struct *first_tid(struct pid *pid, int tid, loff_t f_pos,
for_each_thread(task, pos) {
if (!nr--)
goto found;
- };
+ }
fail:
pos = NULL;
goto out;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] fs: Remove unneeded semicolon
2023-10-26 0:56 [PATCH -next] fs: Remove unneeded semicolon Yang Li
@ 2023-10-26 15:03 ` Oleg Nesterov
2023-10-26 15:23 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Oleg Nesterov @ 2023-10-26 15:03 UTC (permalink / raw)
To: Yang Li; +Cc: akpm, linux-kernel, linux-fsdevel, Abaci Robot
On 10/26, Yang Li wrote:
>
> @@ -3826,7 +3826,7 @@ static struct task_struct *first_tid(struct pid *pid, int tid, loff_t f_pos,
> for_each_thread(task, pos) {
> if (!nr--)
> goto found;
> - };
> + }
Ah, I forgot to remove this semicolon :/
This is on top of
document-while_each_thread-change-first_tid-to-use-for_each_thread.patch
perhaps this cleanup can be folded into the patch above along with Yang's sob ?
If Yang doesn't object.
Oleg.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] fs: Remove unneeded semicolon
2023-10-26 15:03 ` Oleg Nesterov
@ 2023-10-26 15:23 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2023-10-26 15:23 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: Yang Li, linux-kernel, linux-fsdevel, Abaci Robot
On Thu, 26 Oct 2023 17:03:35 +0200 Oleg Nesterov <oleg@redhat.com> wrote:
> On 10/26, Yang Li wrote:
> >
> > @@ -3826,7 +3826,7 @@ static struct task_struct *first_tid(struct pid *pid, int tid, loff_t f_pos,
> > for_each_thread(task, pos) {
> > if (!nr--)
> > goto found;
> > - };
> > + }
>
> Ah, I forgot to remove this semicolon :/
>
> This is on top of
>
> document-while_each_thread-change-first_tid-to-use-for_each_thread.patch
>
> perhaps this cleanup can be folded into the patch above along with Yang's sob ?
The above is in mainline, so no squashing. I added your acked-by.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-26 15:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-26 0:56 [PATCH -next] fs: Remove unneeded semicolon Yang Li
2023-10-26 15:03 ` Oleg Nesterov
2023-10-26 15:23 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).