From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <brauner@kernel.org>
Cc: Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@lst.de>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 05/10] bdev: implement freeze and thaw holder operations
Date: Fri, 27 Oct 2023 08:29:49 +0200 [thread overview]
Message-ID: <20231027062949.GC9109@lst.de> (raw)
In-Reply-To: <20231026-ungewiss-sinken-ea11cd5002da@brauner>
On Thu, Oct 26, 2023 at 10:44:27AM +0200, Christian Brauner wrote:
> */
> int bdev_freeze(struct block_device *bdev)
> {
> int error = 0;
>
> mutex_lock(&bdev->bd_fsfreeze_mutex);
>
> + if (atomic_inc_return(&bdev->bd_fsfreeze_count) > 1) {
> + mutex_unlock(&bdev->bd_fsfreeze_mutex);
> + return 0;
Use a goto out_unlock here to share the lock release with the
main flow?
> /*
> + * If the superblock wasn't already SB_DYING then we hold
> + * s_umount and can safely drop our temporary reference.
> + */
Spaces instead of tabs here.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-10-27 6:30 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 13:01 [PATCH v2 00/10] Implement freeze and thaw as holder operations Christian Brauner
2023-10-24 13:01 ` [PATCH v2 01/10] fs: massage locking helpers Christian Brauner
2023-10-25 12:34 ` Jan Kara
2023-10-25 13:21 ` Christian Brauner
2023-10-25 14:01 ` Jan Kara
2023-10-27 6:25 ` Christoph Hellwig
2023-10-24 13:01 ` [PATCH v2 02/10] bdev: rename freeze and thaw helpers Christian Brauner
2023-10-24 13:01 ` [PATCH v2 03/10] bdev: surface the error from sync_blockdev() Christian Brauner
2023-10-24 15:14 ` Darrick J. Wong
2023-10-25 12:36 ` Jan Kara
2023-10-27 6:25 ` Christoph Hellwig
2023-10-24 13:01 ` [PATCH v2 04/10] bdev: add freeze and thaw holder operations Christian Brauner
2023-10-27 6:26 ` Christoph Hellwig
2023-10-24 13:01 ` [PATCH v2 05/10] bdev: implement " Christian Brauner
2023-10-24 15:21 ` Darrick J. Wong
2023-10-25 14:01 ` Jan Kara
2023-10-26 8:44 ` Christian Brauner
2023-10-26 9:31 ` Jan Kara
2023-10-27 6:29 ` Christoph Hellwig [this message]
2023-10-24 13:01 ` [PATCH v2 06/10] fs: remove get_active_super() Christian Brauner
2023-10-24 13:01 ` [PATCH v2 07/10] super: remove bd_fsfreeze_sb Christian Brauner
2023-10-24 13:01 ` [PATCH v2 08/10] fs: remove unused helper Christian Brauner
2023-10-27 6:30 ` Christoph Hellwig
2023-10-24 13:01 ` [PATCH v2 09/10] porting: document block device freeze and thaw changes Christian Brauner
2023-10-24 15:17 ` Darrick J. Wong
2023-10-25 14:05 ` Jan Kara
2023-10-24 13:01 ` [PATCH v2 10/10] blkdev: comment fs_holder_ops Christian Brauner
2023-10-24 15:16 ` Darrick J. Wong
2023-10-25 14:06 ` Jan Kara
2023-10-25 14:27 ` Christoph Hellwig
2023-10-26 11:45 ` [PATCH v2 00/10] Implement freeze and thaw as holder operations Christian Brauner
2023-10-27 6:40 ` Christoph Hellwig
2023-10-27 11:03 ` Jan Kara
2023-10-27 13:20 ` [PATCH] fs: streamline thaw_super_locked Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231027062949.GC9109@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).