linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [RFC PATCH] fs: make s_count atomic_t
Date: Mon, 6 Nov 2023 18:08:31 +0000	[thread overview]
Message-ID: <20231106180831.GU1957730@ZenIV> (raw)
In-Reply-To: <20231103081907.GD16854@lst.de>

On Fri, Nov 03, 2023 at 09:19:08AM +0100, Christoph Hellwig wrote:
> Same feeling as Jan here - this looks fine to me, but I wonder if there's
> much of a need.  Maybe run it past Al if he has any opinion?

[resurfaces from dcache stuff]

TBH, I'd rather see documentation of struct super_block life cycle
rules written up, just to see what ends up being too ugly to document ;-/
I have old notes on that stuff, but they are pretty much invalidated by
the rework that happened this summer...

I don't hate making ->s_count atomic, but short of real evidence that
sb_lock gets serious contention, I don't see much point either way.

PS: Re dcache - I've a growing branch with a bunch of massage in that area,
plus the local attempt at documentation that will go there.  How are we
going to manage the trees?  The coming cycle I'm probably back to normal
amount of activity; the summer had been a fucking nightmare, but the things
have settled down by now...  <looks> at least 5 topical branches, just
going by what I've got at the moment.

  reply	other threads:[~2023-11-06 18:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-27  9:35 [RFC PATCH] fs: make s_count atomic_t Christian Brauner
2023-11-02 13:48 ` Jan Kara
2023-11-02 16:05   ` Christian Brauner
2023-11-03  8:19 ` Christoph Hellwig
2023-11-06 18:08   ` Al Viro [this message]
2023-11-07 15:01     ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231106180831.GU1957730@ZenIV \
    --to=viro@zeniv.linux.org.uk \
    --cc=brauner@kernel.org \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).