From: Josef Bacik <josef@toxicpanda.com>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"kernel-team@fb.com" <kernel-team@fb.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"brauner@kernel.org" <brauner@kernel.org>
Subject: Re: [PATCH 06/18] btrfs: split out ro->rw and rw->ro helpers into their own functions
Date: Wed, 8 Nov 2023 10:52:21 -0500 [thread overview]
Message-ID: <20231108155221.GA458562@perftesting> (raw)
In-Reply-To: <1a5369c6-24e0-45dd-a867-5844e8171fb9@wdc.com>
On Tue, Nov 07, 2023 at 03:16:50PM +0000, Johannes Thumshirn wrote:
> On 06.11.23 23:09, Josef Bacik wrote:
> > + if (btrfs_super_log_root(fs_info->super_copy) != 0) {
> > + btrfs_warn(fs_info,
> > + "mount required to replay tree-log, cannot remount read-write");
> > + return -EINVAL;
> > + }
>
> I get that this is only a copy of the old code, but if you have to
> re-spin the series:
>
> ret = btrfs_super_log_root(fs_info->super_copy);
> if (ret) {
> /* [...] */
> }
This tells us the bytenr, it's not a return value. Thanks,
Josef
next prev parent reply other threads:[~2023-11-08 15:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 22:08 [PATCH 00/18] btrfs: convert to the new mount API Josef Bacik
2023-11-06 22:08 ` [PATCH 01/18] fs: indicate request originates from old mount api Josef Bacik
2023-11-08 7:59 ` Christoph Hellwig
2023-11-06 22:08 ` [PATCH 02/18] btrfs: split out the mount option validation code into its own helper Josef Bacik
2023-11-06 22:08 ` [PATCH 03/18] btrfs: set default compress type at btrfs_init_fs_info time Josef Bacik
2023-11-06 22:08 ` [PATCH 04/18] btrfs: move space cache settings into open_ctree Josef Bacik
2023-11-07 15:14 ` Johannes Thumshirn
2023-11-06 22:08 ` [PATCH 05/18] btrfs: do not allow free space tree rebuild on extent tree v2 Josef Bacik
2023-11-06 22:08 ` [PATCH 06/18] btrfs: split out ro->rw and rw->ro helpers into their own functions Josef Bacik
2023-11-07 15:16 ` Johannes Thumshirn
2023-11-08 15:52 ` Josef Bacik [this message]
2023-11-06 22:08 ` [PATCH 07/18] btrfs: add a NOSPACECACHE mount option flag Josef Bacik
2023-11-06 22:08 ` [PATCH 08/18] btrfs: add fs_parameter definitions Josef Bacik
2023-11-06 22:08 ` [PATCH 09/18] btrfs: add parse_param callback for the new mount api Josef Bacik
2023-11-06 22:08 ` [PATCH 10/18] btrfs: add fs context handling functions Josef Bacik
2023-11-08 8:46 ` Christian Brauner
2023-11-06 22:08 ` [PATCH 11/18] btrfs: add reconfigure callback for fs_context Josef Bacik
2023-11-06 22:08 ` [PATCH 12/18] btrfs: add get_tree callback for new mount API Josef Bacik
2023-11-08 9:00 ` Christian Brauner
2023-11-06 22:08 ` [PATCH 13/18] btrfs: handle the ro->rw transition for mounting different subovls Josef Bacik
2023-11-08 8:41 ` Christian Brauner
2023-11-08 15:53 ` Josef Bacik
2023-11-06 22:08 ` [PATCH 14/18] btrfs: switch to the new mount API Josef Bacik
2023-11-08 9:03 ` Christian Brauner
2023-11-06 22:08 ` [PATCH 15/18] btrfs: move the device specific mount options to super.c Josef Bacik
2023-11-06 22:08 ` [PATCH 16/18] btrfs: remove old mount API code Josef Bacik
2023-11-06 22:08 ` [PATCH 17/18] btrfs: move one shot mount option clearing to super.c Josef Bacik
2023-11-06 22:08 ` [PATCH 18/18] btrfs: set clear_cache if we use usebackuproot Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231108155221.GA458562@perftesting \
--to=josef@toxicpanda.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=brauner@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).