From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id D819118C29
	for <linux-fsdevel@vger.kernel.org>; Thu,  9 Nov 2023 15:22:53 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SmxYdN+R"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5447C433C8;
	Thu,  9 Nov 2023 15:22:52 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1699543373;
	bh=dV7K9WhlIxEa/n4PDioiDH4FmMaBnmeQjaOVUyxHpPM=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=SmxYdN+R/96uuIss/VayGIxWPbgR7YY0SbTT01p1EkQGdEX6MB4Ph2ZEd31mC3MCx
	 taisuqrJryw8ih9hvtJ44hldiw/DgJ0z2b+Ix3NDVuMA+3QhsYcdqoNyu+OoT2R0r4
	 r1MmWueDwt0LLWw5Q7dTx37Bul36zgc5ZY359GiqycPosa289XVS3H3ISBGcX+rRdW
	 GW/a+TZOudzM4NO/5Q/mQDIQoN23vL2m9OD9e/7C7kO9BiRHI+dIaSWstpMdf0nM2v
	 Z3GF1z+Vm+UqimCq8jV+MKX3PQMqQhhswlhDU+us5z8lf92eADY2P2HwGaGP6+2H+W
	 gBw2JpgzES7cg==
Date: Thu, 9 Nov 2023 16:22:49 +0100
From: Christian Brauner <brauner@kernel.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 12/22] Make retain_dentry() neutral with respect to
 refcounting
Message-ID: <20231109-ursprung-kreide-04fa90cbb000@brauner>
References: <20231109061932.GA3181489@ZenIV>
 <20231109062056.3181775-1-viro@zeniv.linux.org.uk>
 <20231109062056.3181775-12-viro@zeniv.linux.org.uk>
Precedence: bulk
X-Mailing-List: linux-fsdevel@vger.kernel.org
List-Id: <linux-fsdevel.vger.kernel.org>
List-Subscribe: <mailto:linux-fsdevel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-fsdevel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20231109062056.3181775-12-viro@zeniv.linux.org.uk>

On Thu, Nov 09, 2023 at 06:20:46AM +0000, Al Viro wrote:
> retain_dentry() used to decrement refcount if and only if it returned
> true.  Lift those decrements into the callers.
> 
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---

Looks good to me,
Reviewed-by: Christian Brauner <brauner@kernel.org>