From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id E002FFBF1
	for <linux-fsdevel@vger.kernel.org>; Thu,  9 Nov 2023 07:39:46 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l0iDPaVw"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5683BC433C8;
	Thu,  9 Nov 2023 07:39:46 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1699515586;
	bh=VlSIsIgqyWIBkdurEt7sHqt+bxDyaPIL6Ehg14Nv8EE=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=l0iDPaVwOPkiUAMuAF76Caf6nQ2TSirlXjCU+GVDKr4ppi4lb3ovbJCcrhNkpEpJc
	 rAkadLtTwPdR3ODwh9m1DoiJpciTp7OUFwzhdr9HbRcLLqMoZQh7T+1I/XrGlJcP7d
	 YW9V+m/GvB08pZZKhf4rZvVvR2BHPD4/NvB/1a3+czxRDkR6+4w10y9dUIZ4i5QM87
	 ThFnfyH7hI9USvUK4S9ciFDSOAZiQ7JDaw2bmkuREZxjS1aF1JtBsn2WVHvCsljGoI
	 CCuTeoFZi6FFVF0kSvKe/b/k1LN0o6I6u6a7qW4nHC3WYkWSvFOWRO5Nxpi5gk2Eav
	 8h50eh6G9QU0w==
Date: Wed, 8 Nov 2023 23:39:45 -0800
From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Chandan Babu R <chandanbabu@kernel.org>,
	Jeff Layton <jlayton@kernel.org>,
	Christian Brauner <brauner@kernel.org>, catherine.hoang@oracle.com,
	cheng.lin130@zte.com.cn, dchinner@redhat.com,
	linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
	osandov@fb.com
Subject: Re: [GIT PULL] xfs: new code for 6.7
Message-ID: <20231109073945.GE1205143@frogsfrogsfrogs>
References: <87fs1g1rac.fsf@debian-BULLSEYE-live-builder-AMD64>
 <CAHk-=wj3oM3d-Hw2vvxys3KCZ9De+gBN7Gxr2jf96OTisL9udw@mail.gmail.com>
 <20231108225200.GY1205143@frogsfrogsfrogs>
 <20231109045150.GB28458@lst.de>
Precedence: bulk
X-Mailing-List: linux-fsdevel@vger.kernel.org
List-Id: <linux-fsdevel.vger.kernel.org>
List-Subscribe: <mailto:linux-fsdevel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-fsdevel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231109045150.GB28458@lst.de>

On Thu, Nov 09, 2023 at 05:51:50AM +0100, Christoph Hellwig wrote:
> On Wed, Nov 08, 2023 at 02:52:00PM -0800, Darrick J. Wong wrote:
> > > Also, xfs people may obviously have other preferences for how to deal
> > > with the whole "now using tv_sec in the VFS inode as a 64-bit sequence
> > > number" thing, and maybe you prefer to then update my fix to this all.
> > > But that horrid casts certainly wasn't the right way to do it.
> > 
> > Yeah, I can work on that for the rt modernization patchset.
> 
> As someone who has just written some new code stealing this trick I
> actually have a todo list item to make this less horrible as the cast
> upset my stomache.  But shame on me for not actually noticing that it
> is buggy as well (which honestly should be the standard assumption for
> casts like this).

Dave and I started looking at this too, and came up with: For rtgroups
filesystems, what if rtpick simply rotored the rtgroups?  And what if we
didn't bother persisting the rotor value, which would make this casting
nightmare go away in the long run.  It's not like we persist the agi
rotors.

--D