From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Chandan Babu R <chandanbabu@kernel.org>,
Jeff Layton <jlayton@kernel.org>,
Christian Brauner <brauner@kernel.org>,
catherine.hoang@oracle.com, cheng.lin130@zte.com.cn,
dchinner@redhat.com, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org, osandov@fb.com
Subject: Re: [GIT PULL] xfs: new code for 6.7
Date: Thu, 9 Nov 2023 17:50:57 +0100 [thread overview]
Message-ID: <20231109165057.GA8083@lst.de> (raw)
In-Reply-To: <20231109163856.GG1205143@frogsfrogsfrogs>
On Thu, Nov 09, 2023 at 08:38:56AM -0800, Darrick J. Wong wrote:
> Dave suggested that we might restore the pre-4.6 behavior by explicitly
> encoding what we used to do:
>
> inode->i_atime.tv_sec = seq & 0xFFFFFFFF;
> inode->i_atime.tv_nsec = seq >> 32;
>
> (There's a helper in 6.7 for this, apparently.)
>
> But then I pointed out that the entire rtpick sequence counter thing
> merely provides a *starting point* for rtbitmap searches. So it's not
> like garbled values result in metadata inconsistency. IOWs, it's
> apparently benign.
>
> IOWs, how much does anyone care about improving on Linus' fixup?
I'd really like to see the cast of a pointer to a struct type to a
scalar gone, because those tend to hide bugs.
I'm not going to bother you too much with it, promised.
next prev parent reply other threads:[~2023-11-09 16:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 9:56 [GIT PULL] xfs: new code for 6.7 Chandan Babu R
2023-11-08 21:29 ` Linus Torvalds
2023-11-08 22:52 ` Darrick J. Wong
2023-11-09 4:51 ` Christoph Hellwig
2023-11-09 7:39 ` Darrick J. Wong
2023-11-09 14:46 ` Christoph Hellwig
2023-11-09 16:38 ` Darrick J. Wong
2023-11-09 16:50 ` Christoph Hellwig [this message]
2023-11-09 22:05 ` Dave Chinner
2023-11-09 17:12 ` Jeff Layton
2023-11-08 21:34 ` pr-tracker-bot
-- strict thread matches above, loose matches on Subject: below --
2023-11-25 12:47 Chandan Babu R
2023-11-25 17:13 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231109165057.GA8083@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=catherine.hoang@oracle.com \
--cc=chandanbabu@kernel.org \
--cc=cheng.lin130@zte.com.cn \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=osandov@fb.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).