From: Al Viro <viro@zeniv.linux.org.uk>
To: Stephen Smalley <stephen.smalley.work@gmail.com>
Cc: Paul Moore <paul@paul-moore.com>,
Christian Brauner <brauner@kernel.org>,
selinux@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH][RFC] selinuxfs: saner handling of policy reloads
Date: Tue, 14 Nov 2023 21:57:24 +0000 [thread overview]
Message-ID: <20231114215724.GV1957730@ZenIV> (raw)
In-Reply-To: <20231114215341.GU1957730@ZenIV>
On Tue, Nov 14, 2023 at 09:53:41PM +0000, Al Viro wrote:
> On Tue, Nov 14, 2023 at 03:57:35PM -0500, Stephen Smalley wrote:
> > On Mon, Nov 13, 2023 at 11:19 AM Paul Moore <paul@paul-moore.com> wrote:
> > >
> > > On Mon, Oct 16, 2023 at 6:08 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
> > > >
> > > > [
> > > > That thing sits in viro/vfs.git#work.selinuxfs; I have
> > > > lock_rename()-related followups in another branch, so a pull would be more
> > > > convenient for me than cherry-pick. NOTE: testing and comments would
> > > > be very welcome - as it is, the patch is pretty much untested beyond
> > > > "it builds".
> > > > ]
> > >
> > > Hi Al,
> > >
> > > I will admit to glossing over the comment above when I merged this
> > > into the selinux/dev branch last night. As it's been a few weeks, I'm
> > > not sure if the comment above still applies, but if it does let me
> > > know and I can yank/revert the patch in favor of a larger pull. Let
> > > me know what you'd like to do.
> >
> > Seeing this during testsuite runs:
>
> Interesting... i_nlink decrement hitting an inode already with zero
> nlink...
>
> <pokes around>
>
> Could you add
> inc_nlink(sb->s_root->d_inode);
> in sel_make_swapover_dir() right before
> inode_unlock(sb->s_root->d_inode);
>
> and check if that fixes the problem?
See git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git #for-selinux
next prev parent reply other threads:[~2023-11-14 21:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 22:08 [PATCH][RFC] selinuxfs: saner handling of policy reloads Al Viro
2023-10-17 20:28 ` Paul Moore
2023-10-18 4:35 ` Al Viro
2023-10-19 1:39 ` Paul Moore
2023-10-19 13:10 ` Stephen Smalley
2023-11-13 3:48 ` Paul Moore
2023-10-19 13:02 ` Stephen Smalley
2023-11-13 16:19 ` Paul Moore
2023-11-14 20:57 ` Stephen Smalley
2023-11-14 21:53 ` Al Viro
2023-11-14 21:57 ` Al Viro [this message]
2023-11-14 22:24 ` Paul Moore
2023-11-15 13:35 ` Stephen Smalley
2023-11-16 13:16 ` Stephen Smalley
2023-11-16 14:30 ` Stephen Smalley
2023-11-16 17:53 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231114215724.GV1957730@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).