From: Al Viro <viro@zeniv.linux.org.uk>
To: Ian Kent <raven@themaw.net>
Cc: Edward Adam Davis <eadavis@qq.com>,
syzbot+662f87a8ef490f45fa64@syzkaller.appspotmail.com,
autofs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] autofs: fix null deref in autofs_fill_super
Date: Wed, 15 Nov 2023 00:35:27 +0000 [thread overview]
Message-ID: <20231115003527.GW1957730@ZenIV> (raw)
In-Reply-To: <7b982b5e-ecad-1b55-7388-faf759b65cfe@themaw.net>
On Wed, Nov 15, 2023 at 08:18:33AM +0800, Ian Kent wrote:
> I guess that including the locking is not going to make much difference.
>
> I don't remember now but it was probably done because there may be many
>
> mounts (potentially several thousand) being done and I wanted to get rid
>
> of anything that wasn't needed.
Seeing that lock in question is not going to be contended... ;-)
Seriously, though - the fewer complications we have in the locking rules,
the better.
Al, currently going through audit of ->d_name/->d_parent uses and cursing
at the 600-odd places left to look through...
next prev parent reply other threads:[~2023-11-15 0:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 1:02 [syzbot] [autofs?] general protection fault in autofs_fill_super syzbot
2023-11-14 3:52 ` [PATCH] autofs: fix null deref " Edward Adam Davis
2023-11-14 4:25 ` Ian Kent
2023-11-14 4:41 ` Al Viro
2023-11-14 8:30 ` Ian Kent
2023-11-14 15:26 ` Al Viro
2023-11-15 0:18 ` Ian Kent
2023-11-15 0:35 ` Al Viro [this message]
2023-11-15 1:06 ` Ian Kent
2023-11-14 5:48 ` [PATCH V2] autofs: fix null ptr " Edward Adam Davis
2023-11-16 9:51 ` [syzbot] [autofs?] general protection fault " syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231115003527.GW1957730@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=autofs@vger.kernel.org \
--cc=eadavis@qq.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=syzbot+662f87a8ef490f45fa64@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).