From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AF3B1BDE1; Mon, 20 Nov 2023 14:02:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="guWpBVNR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CF78C433C8; Mon, 20 Nov 2023 14:02:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700488957; bh=FCrmZ65nO1A52VtVMBc8whDn/taxA3mU5UI2kUhmaBc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=guWpBVNRYMm597lpO9bdcyXMBxX2ZOKL54b3ONVQMl2r6M1sVbA3ntY+anjCWwu+G l9G1hCcXaWFzztr61p92+zv1vtW3ruDSqjMYcGv2u3w7wmmDDtFn38NlTKfoUviD/8 /EsINeGMXuz+GISsqakEWIMjJA051VhFGikrOQaTmvnzM1/FNXRpogPJCou3TXv2cn PJyuERk9vkLmc2oI5SZyQV9eK92i6VL59ut61dCI+hBldU8vUn/7YN0bxXfuc1VrVS 3mYECa+fU8JK78i7NaRCPQIuB0l1Y9QX2hLt8I0034PV7U6HVC6Nc99Y2UVegx0Ynp PVwdYgEpO0/XA== From: Christian Brauner To: Ian Kent Cc: Christian Brauner , Bill O'Donnell , Kernel Mailing List , autofs mailing list , linux-fsdevel , syzbot+662f87a8ef490f45fa64@syzkaller.appspotmail.com, Al Viro Subject: Re: [PATCH v2] autofs: add: new_inode check in autofs_fill_super() Date: Mon, 20 Nov 2023 15:01:55 +0100 Message-ID: <20231120-dergleichen-parkverbot-dbfcafdc0c26@brauner> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231119225319.331156-1-raven@themaw.net> References: <20231119225319.331156-1-raven@themaw.net> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1188; i=brauner@kernel.org; h=from:subject:message-id; bh=Tnvki9Nfk5bjCuJJqhEtlw/13JFN9XNgay+otjhGek0=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaRGp13W+LxKUurNC1s+x59cvw/7tMrVTeWWbEvUde+7n 1TyNEm1o5SFQYyLQVZMkcWh3SRcbjlPxWajTA2YOaxMIEMYuDgFYCIPnzAynO3sWrh7xged89FF jsZvkuYI6l/6JfOsfN2E10LHDs9/8p3hf+TLLN2HwQsYFGON0r7e38rmVPS8Nrli41ympPWdLQs FeQA= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit On Mon, 20 Nov 2023 06:53:19 +0800, Ian Kent wrote: > Add missing NULL check of root_inode in autofs_fill_super(). > > While we are at it simplify the logic by taking advantage of the VFS > cleanup procedures and get rid of the goto error handling, as suggested > by Al Viro. > > > [...] I've removed an unused variable. I also changed it so that it errors out right after autofs_get_inode() returns NULL. --- Applied to the vfs.fixes branch of the vfs/vfs.git tree. Patches in the vfs.fixes branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.fixes [1/1] autofs: add: new_inode check in autofs_fill_super() https://git.kernel.org/vfs/vfs/c/368e8258536e