From: Jan Harkes <jaharkes@cs.cmu.edu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Christian Brauner <brauner@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Jens Axboe <axboe@kernel.dk>, Miklos Szeredi <miklos@szeredi.hu>,
David Howells <dhowells@redhat.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] coda: change locking order in coda_file_write_iter()
Date: Mon, 20 Nov 2023 09:13:14 -0500 [thread overview]
Message-ID: <20231120141314.soxwn4zuh57ktuxk@cs.cmu.edu> (raw)
In-Reply-To: <20231120095110.2199218-1-amir73il@gmail.com>
On Mon, Nov 20, 2023 at 11:51:10AM +0200, Amir Goldstein wrote:
> The coda host file is a backing file for the coda inode on a different
> filesystem than the coda inode.
>
> Change the locking order to take the coda inode lock before taking
> the backing host file freeze protection, same as in ovl_write_iter()
> and in network filesystems that use cachefiles.
>
> Link: https://lore.kernel.org/r/CAOQ4uxjcnwuF1gMxe64WLODGA_MyAy8x-DtqkCUxqVQKk3Xbng@mail.gmail.com/
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Acked-by: Jan Harkes <jaharkes@cs.cmu.edu
Looks good, it makes sense to use the same lock ordering as the other
file systems. Thanks for pushing this along.
Jan
prev parent reply other threads:[~2023-11-20 14:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 9:51 [PATCH] coda: change locking order in coda_file_write_iter() Amir Goldstein
2023-11-20 14:13 ` Jan Harkes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231120141314.soxwn4zuh57ktuxk@cs.cmu.edu \
--to=jaharkes@cs.cmu.edu \
--cc=amir73il@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).