From: Josef Bacik <josef@toxicpanda.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Christian Brauner <brauner@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: Rename mapping private members
Date: Mon, 20 Nov 2023 12:01:16 -0500 [thread overview]
Message-ID: <20231120170116.GB1606827@perftesting> (raw)
In-Reply-To: <20231117215823.2821906-1-willy@infradead.org>
On Fri, Nov 17, 2023 at 09:58:23PM +0000, Matthew Wilcox (Oracle) wrote:
> It is hard to find where mapping->private_lock, mapping->private_list and
> mapping->private_data are used, due to private_XXX being a relatively
> common name for variables and structure members in the kernel. To fit
> with other members of struct address_space, rename them all to have an
> i_ prefix. Tested with an allmodconfig build.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
Given that there's plenty of other things with i_ in there I think this is a
reasonable naming scheme. I agree with Darrick that maybe a_ would be better,
but we'd have to change everything in there and that's a bit trickier.
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Thanks,
Josef
next prev parent reply other threads:[~2023-11-20 17:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 21:58 [PATCH] fs: Rename mapping private members Matthew Wilcox (Oracle)
2023-11-17 22:04 ` Darrick J. Wong
2023-11-17 22:13 ` Matthew Wilcox
2023-11-17 23:26 ` Al Viro
2023-11-20 15:10 ` Christian Brauner
2023-11-20 15:13 ` Christian Brauner
2023-11-21 1:44 ` Darrick J. Wong
2023-11-20 17:01 ` Josef Bacik [this message]
2023-11-21 11:03 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231120170116.GB1606827@perftesting \
--to=josef@toxicpanda.com \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).