linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-fsdevel@vger.kernel.org
Subject: Re: [viro-vfs:work.csum-x86 4/18] net/core/datagram.c:745:55: sparse: sparse: incorrect type in argument 1 (different base types)
Date: Fri, 24 Nov 2023 18:29:38 +0000	[thread overview]
Message-ID: <20231124182938.GY38156@ZenIV> (raw)
In-Reply-To: <202311250023.ySjyjo9L-lkp@intel.com>

On Sat, Nov 25, 2023 at 01:50:33AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.csum-x86
> head:   f6c1313680f1d2319d2061c63abeb76f820319b8
> commit: 90c2bfd06916ac7c05129b36683bfd3424d8e0e4 [4/18] Fix the csum_and_copy_..._user() idiocy
> config: x86_64-randconfig-123-20231124 (https://download.01.org/0day-ci/archive/20231125/202311250023.ySjyjo9L-lkp@intel.com/config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231125/202311250023.ySjyjo9L-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202311250023.ySjyjo9L-lkp@intel.com/
> 
> sparse warnings: (new ones prefixed by >>)
> >> net/core/datagram.c:745:55: sparse: sparse: incorrect type in argument 1 (different base types) @@     expected restricted __wsum [usertype] v @@     got restricted __wsum_fault [usertype] next @@
>    net/core/datagram.c:745:55: sparse:     expected restricted __wsum [usertype] v
>    net/core/datagram.c:745:55: sparse:     got restricted __wsum_fault [usertype] next
> >> net/core/datagram.c:745:54: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected restricted __wsum [usertype] csum2 @@     got restricted __wsum_fault @@
>    net/core/datagram.c:745:54: sparse:     expected restricted __wsum [usertype] csum2
>    net/core/datagram.c:745:54: sparse:     got restricted __wsum_fault
>    net/core/datagram.c: note: in included file (through include/linux/skbuff.h, include/net/net_namespace.h, include/linux/inet.h):
>    include/net/checksum.h:36:17: sparse: sparse: incorrect type in return expression (different base types) @@     expected restricted __wsum_fault @@     got restricted __wsum [usertype] @@
>    include/net/checksum.h:36:17: sparse:     expected restricted __wsum_fault
>    include/net/checksum.h:36:17: sparse:     got restricted __wsum [usertype]
> --
> >> net/core/skbuff.c:6971:55: sparse: sparse: incorrect type in argument 1 (different base types) @@     expected restricted __wsum [usertype] v @@     got restricted __wsum_fault [usertype] next @@
>    net/core/skbuff.c:6971:55: sparse:     expected restricted __wsum [usertype] v
>    net/core/skbuff.c:6971:55: sparse:     got restricted __wsum_fault [usertype] next
> >> net/core/skbuff.c:6971:54: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected restricted __wsum [usertype] csum2 @@     got restricted __wsum_fault @@
>    net/core/skbuff.c:6971:54: sparse:     expected restricted __wsum [usertype] csum2
>    net/core/skbuff.c:6971:54: sparse:     got restricted __wsum_fault
>    net/core/skbuff.c: note: in included file (through include/net/net_namespace.h, include/linux/inet.h):
>    include/linux/skbuff.h:2703:28: sparse: sparse: self-comparison always evaluates to false
>    net/core/skbuff.c: note: in included file (through include/linux/skbuff.h, include/net/net_namespace.h, include/linux/inet.h):
>    include/net/checksum.h:36:17: sparse: sparse: incorrect type in return expression (different base types) @@     expected restricted __wsum_fault @@     got restricted __wsum [usertype] @@
>    include/net/checksum.h:36:17: sparse:     expected restricted __wsum_fault
>    include/net/checksum.h:36:17: sparse:     got restricted __wsum [usertype]

Gyah... misannotated from_wsum_fault() - argument is __wsum_fault and
result is __wsum, not the other way round.  Fixed and force-pushed...

      reply	other threads:[~2023-11-24 18:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-24 17:50 [viro-vfs:work.csum-x86 4/18] net/core/datagram.c:745:55: sparse: sparse: incorrect type in argument 1 (different base types) kernel test robot
2023-11-24 18:29 ` Al Viro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231124182938.GY38156@ZenIV \
    --to=viro@zeniv.linux.org.uk \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).